New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove state_in_rotating_frame parameter #2172

Merged

zingale merged 1 commit into AMReX-Astro:development from maxpkatz:rm_state_in_rotating_frame

May 2, 2022

Member

maxpkatz commented May 2, 2022

PR summary

This was an interesting experiment but ultimately did not seem to help too much.

PR checklist

test suite needs to be run on this PR
this PR will change answers in the test suite to more than roundoff level
all newly-added functions have docstrings as per the coding conventions
the CHANGES file has been updated, if appropriate
if appropriate, this change is described in the docs


          Remove state_in_rotating_frame parameter

834e19d

Member

zingale commented May 2, 2022

all rotating tests pass: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2022-05-02-003/index.html

zingale approved these changes

View reviewed changes

zingale merged commit 1289eca into AMReX-Astro:development

maxpkatz deleted the rm_state_in_rotating_frame branch

May 2, 2022 19:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment