Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove castro.show_center_of_mass #2176

Merged
merged 1 commit into from
May 3, 2022

Conversation

maxpkatz
Copy link
Member

@maxpkatz maxpkatz commented May 3, 2022

PR summary

The center of mass is now calculated and displayed by default if we're already doing sums. The additional marginal cost of this sum is not high, so we should just simplify the code.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member

zingale commented May 3, 2022

@zingale zingale merged commit 67ad0c6 into AMReX-Astro:development May 3, 2022
@maxpkatz maxpkatz deleted the rm_show_center_of_mass branch May 3, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants