turn off use_pslope by default #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this only affects ppm_type = 0, but we will soon extend its functionality to PPM as well. Disabling it by default means that the behavior of most problems will not change. For the inputs files that use gravity and have ppm_type = 0 currently, I've explicitly re-enabled it.
|
tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2022-05-18-001/index.html looks like I need to just fix hse_convergence-SDC2 |
|
this seems to work now: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2022-05-18-003/index.html |
maxpkatz
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this only affects ppm_type = 0, but we will soon extend its functionality
to PPM as well. Disabling it by default means that the behavior of most
problems will not change. For the inputs files that use gravity and have
ppm_type = 0 currently, I've explicitly re-enabled it.
PR summary
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate