Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for early stopping based on exceeding some threshold value #2209

Merged
merged 4 commits into from
May 20, 2022

Conversation

maxpkatz
Copy link
Member

PR summary

This was originally developed for wdmerger and Detonation, but now all applications should be able to use it.

amr.message_int is overridden to be 1 by default to support this.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@maxpkatz maxpkatz marked this pull request as ready for review May 20, 2022 11:43
@zingale
Copy link
Member

zingale commented May 20, 2022

tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2022-05-20-002/index.html

I think the diffs are because it doesn't have all of the changes on development

@maxpkatz
Copy link
Member Author

Merged with development

@zingale
Copy link
Member

zingale commented May 20, 2022

can you also update the docs here:
https://amrex-astro.github.io/Castro/docs/timestepping.html

@maxpkatz
Copy link
Member Author

can you also update the docs here: https://amrex-astro.github.io/Castro/docs/timestepping.html

I could, but this isn't really a timestepping constraint, so it seems a little out of place.

@zingale
Copy link
Member

zingale commented May 20, 2022

okay. I just thought since at the top we list stopping criteria. But we should find somewhere else to doc this.

@zingale zingale merged commit f507f24 into AMReX-Astro:development May 20, 2022
@maxpkatz maxpkatz deleted the early_stopping branch June 18, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants