Optimize no-subcycling AMR #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpkatz
force-pushed
the
optimal_subcycling_prep
branch
from
ec72819
to
5f923c1
Compare
|
tests: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-07-08/index.html wdmerger 3d changes by roundoff |
zingale
reviewed
Jul 9, 2023
zingale
approved these changes
Jul 9, 2023
5 tasks
zingale
pushed a commit
that referenced
this pull request
Jul 18, 2023
As a follow-up to #2505, for non-subcycling advances we can skip burning if we're not on a "leaf" zone (i.e. a zone not covered by any fine levels). These zones will be updated by an avgDown() in post_timestep().
5 tasks
zingale
pushed a commit
that referenced
this pull request
Oct 17, 2023
The castro.use_post_step_regrid parameter doesn't make sense when we're not subcycling. By the time we finish the coarse step we will already have finished all of the fine timesteps (thanks to the recent change in #2505), so there's nothing left to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
The approach described in #276 is implemented to optimize the performance of the case where no subcycling is occurring. When Poisson gravity is enabled, this allows for a single composite solve (across all levels) per coarse step, as opposed to multiple level solves, which are significantly less efficient, particularly on GPUs. This results in a significant performance boost for problems with Poisson gravity that do not subcycle.
PR checklist
CHANGESfile has been updated, if appropriate