Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize on USE_MPI = TRUE in all makefiles #2641

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Standardize on USE_MPI = TRUE in all makefiles #2641

merged 5 commits into from
Oct 19, 2023

Conversation

maxpkatz
Copy link
Member

PR summary

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member

zingale commented Oct 19, 2023

we might want to setup an action to enforce some basic standards in the GNUmakefile. I can do that if we can agree on what we want

like

  • COMP = gnu
  • USE_CUDA = FALSE
  • USE_MPI = TRUE
  • DEBUG = FALSE

etc.

@maxpkatz maxpkatz marked this pull request as ready for review October 19, 2023 12:57
@zingale zingale merged commit ec8279a into AMReX-Astro:development Oct 19, 2023
18 checks passed
@maxpkatz maxpkatz deleted the standardized_use_mpi branch October 19, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zingale zingale zingale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxpkatz @zingale