Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix zero of burn_weights in retry #2826

Merged
merged 1 commit into from
Apr 16, 2024
Merged

fix zero of burn_weights in retry #2826

merged 1 commit into from
Apr 16, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 14, 2024

we only need to setVal if we allocated burn_weights

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
fix zero of burn_weights in retry
55e2d40 
we only need to setVal if we allocated burn_weights
@zingale zingale merged commit 5cacc94 into AMReX-Astro:development Apr 16, 2024
25 checks passed
@zingale zingale deleted the fix_burn_weights branch April 16, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanakbhargava khanakbhargava khanakbhargava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zingale @khanakbhargava