GPU make edge scal 3d (GPU hydro PR 7/n) #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Three tests are failing with roundoff level diffs: |
|
I've run these again and they seem to agree now |
…OeX into gpu_make_edge_scal_3d
zingale
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This offloads
make_edge_scal_3dto the GPU. It has been tested for the 3d reacting bubble & wdconvect problems compiled for MPI and GPU.This also adds in the CUDA launch statements (and does some restructuring of the ppm-dependent routines to enable register capping) so all of the hydro routines offloaded so far now actually run on the GPU.
Note: It is likely that this version will not work if compiled with OpenMP (this will come in a future PR)