Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove reinterpret_cast in rhs.H #1435

Merged
merged 9 commits into from
Mar 15, 2024
Merged

remove reinterpret_cast in rhs.H #1435

merged 9 commits into from
Mar 15, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Jan 2, 2024

No description provided.

@zingale
Copy link
Member Author

zingale commented Jan 2, 2024

tests: http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2024-01-02-003/index.html

@zingale zingale mentioned this pull request Mar 3, 2024
Closed
@zingale
Copy link
Member Author

zingale commented Mar 9, 2024

all tests pass with this change:
http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2024-03-09-002/index.html

yut23
yut23 reviewed Mar 15, 2024
View reviewed changes
networks/rhs.H Outdated
@@ -273,19 +273,17 @@ constexpr int is_jacobian_term_used ()
}

AMREX_GPU_HOST_DEVICE AMREX_INLINE
void dgesl (RArray2D& a1, RArray1D& b1)
void dgesl (RArray2D& a, RArray1D& b)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a can be made const here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

yut23
yut23 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@yut23 yut23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through and did the index shifts for myself, and got the same code.

@zingale zingale merged commit 07a186e into AMReX-Astro:development Mar 15, 2024
27 checks passed
@zingale zingale deleted the rhs_reinterpret_cast branch March 15, 2024 22:22
@zingale zingale mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zingale @yut23