extract some common integrator infrastructure #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks a bit clumsy, so comments welcomed. With this, I can make |
|
I am not sure how to fix the CUDA issues here. It seems to not like passing the integrator function into the |
|
update: |
|
it appears that function points are not supported by SYCL, so we'll need to use functors (e.g., a struct wrapper with an overload of ()) |
this will make it easier to merge a lot of integrator logic
|
requires #1541 |
|
this has been refactored so it will be SYCL compliant now |
zingale
changed the title
maxpkatz
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.