Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Fortran interfaces are enabled #121

Merged
merged 2 commits into from
May 30, 2024

Conversation

gardner48
Copy link
Contributor

When using an existing AMReX install, the top level CMake always calls enable_language(Fortran) so the Fortran compiler is found even if the Fortran interfaces are disabled.

Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
@WeiqunZhang
Copy link
Member

@ax3l Did something change in pyamrex?

@ax3l
Copy link
Member

ax3l commented May 30, 2024

Ah, this is a breaking change from AMReX development from last week (AMReX-Codes/amrex#3956). I updated the interface to pull it in it today: AMReX-Codes/pyamrex#324

Restarting CI now for the PR here.

@ax3l ax3l added the enhancement New feature or request label May 30, 2024
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@ax3l
Copy link
Member

ax3l commented May 30, 2024

That macOS error looks familiar, some breakage in homebrew:

/usr/bin/g++ -Werror -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -fno-operator-names -g -arch arm64 -isysroot /Applications/Xcode_15.0.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names -Wl,-flat_namespace -Wl,-commons,use_dylibs -Wl,-ld_classic CMakeFiles/Advection_AmrCore.dir/Source/AdvancePhiAllLevels.cpp.o CMakeFiles/Advection_AmrCore.dir/Source/AdvancePhiAtLevel.cpp.o CMakeFiles/Advection_AmrCore.dir/Source/AmrCoreAdv.cpp.o CMakeFiles/Advection_AmrCore.dir/Source/DefineVelocity.cpp.o CMakeFiles/Advection_AmrCore.dir/Source/main.cpp.o -o Advection_AmrCore  -Wl,-rpath,/Users/runner/work/amrex-tutorials/amrex-tutorials/ExampleCodes/build/_deps/amrex-build/Src ../../_deps/amrex-build/Src/libamrex_3d.dylib /opt/homebrew/Cellar/open-mpi/5.0.3_1/lib/libmpi_usempif08.dylib /opt/homebrew/Cellar/open-mpi/5.0.3_1/lib/libmpi_usempi_ignore_tkr.dylib /opt/homebrew/Cellar/open-mpi/5.0.3_1/lib/libmpi_mpifh.dylib /opt/homebrew/Cellar/open-mpi/5.0.3_1/lib/libmpi.dylib
ld: warning: directory not found for option '-L/usr/local/opt/gcc/lib/gcc/current'
ld: file not found: @rpath/libquadmath.0.dylib for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@ax3l ax3l merged commit 2595b37 into AMReX-Codes:main May 30, 2024
13 of 14 checks passed
@ax3l ax3l mentioned this pull request May 30, 2024
@gardner48 gardner48 deleted the check-for-fortran-interfaces branch May 30, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants