Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiFab tutorial with pyamrex #95

Merged
merged 9 commits into from
Aug 15, 2023
Merged

Conversation

EZoni
Copy link
Contributor

@EZoni EZoni commented Jul 12, 2023

Thank you to @RevathiJambunathan, @oshapoval, @dpgrote, @kngott and @ax3l for the teamwork.

Rewrite the "MultiFab" guided tutorial using pyamrex. Outstanding questions marked as "TODO" comments.

@etpalmer63
Copy link
Collaborator

Looks super cool!

Just a reminder, that if you want to add the example to the CI/CD testing, the method for build and test for the Python code is likely different than the existing examples.

@EZoni
Copy link
Contributor Author

EZoni commented Jul 17, 2023

Sounds good, thanks! Yes, I'm not sure how tutorials are treated with respect to CI/CD testing in AMReX. I will probably discuss this with @WeiqunZhang or @atmyers during the next part of the NERSC hackathon later this week.

@EZoni
Copy link
Contributor Author

EZoni commented Aug 5, 2023

@ax3l @RevathiJambunathan @kngott

I think this is ready for review. The test now shows both ways to fill an array on a given box (NumPy operations and standard for loop over box indices), and compares two arrays filled with these methods.

I'm also using the function write_single_level_plotfile now available in pyamrex, as well as the IOProcessor function to make sure that we print only from the IO process.

@EZoni EZoni changed the title [WIP] MultiFab tutorial with pyamrex MultiFab tutorial with pyamrex Aug 7, 2023
@ax3l
Copy link
Member

ax3l commented Aug 11, 2023

I finalized the example TODO markers and added CI :)

@ax3l
Copy link
Member

ax3l commented Aug 11, 2023

Documentation added as well :)

@ax3l ax3l added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 11, 2023
@ax3l
Copy link
Member

ax3l commented Aug 14, 2023

@EZoni @atmyers @etpalmer63 ready to go :)

@ax3l
Copy link
Member

ax3l commented Aug 15, 2023

@EZoni @atmyers @etpalmer63 @WeiqunZhang ping :)

@atmyers atmyers merged commit 63c05a8 into AMReX-Codes:main Aug 15, 2023
14 checks passed
@ax3l ax3l mentioned this pull request Aug 15, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants