Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: fix ENABLE_PROFPARSER and ENABLE_SENSEI options #1428

Merged
merged 2 commits into from
Oct 1, 2020
Merged

CMake: fix ENABLE_PROFPARSER and ENABLE_SENSEI options #1428

merged 2 commits into from
Oct 1, 2020

Conversation

mic84
Copy link
Contributor

@mic84 mic84 commented Sep 30, 2020

Summary

Fixes #1426

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@mic84 mic84 requested review from ax3l and atmyers September 30, 2020 21:53
@mic84 mic84 mentioned this pull request Sep 30, 2020
Closed
@ax3l ax3l added the install label Sep 30, 2020
@ax3l ax3l mentioned this pull request Sep 30, 2020
Merged
@mic84 mic84 merged commit 3371d52 into AMReX-Codes:development Oct 1, 2020
@mic84 mic84 deleted the mr/cmake-fix-options branch October 1, 2020 05:58
dwillcox pushed a commit to dwillcox/amrex that referenced this pull request Oct 3, 2020
@mic84 @dwillcox
CMake: fix ENABLE_PROFPARSER and ENABLE_SENSEI options (AMReX-Codes#1428
043ab20 
)

* CMake: fix incorrect option

* CMake: fix ENABLE_SENSEI option
@sayerhs sayerhs mentioned this pull request Nov 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

@atmyers atmyers Awaiting requested review from atmyers

Assignees
No one assigned
Labels
install
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question regarding CMake variables
2 participants
@mic84 @ax3l