Speedup clang tidy #3219
Merged
Speedup clang tidy #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depend on #3218. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| args = parser.parse_args() | ||
|
|
||
| fin = open(args.input, "r") | ||
| fout = open(args.output, "w") |
Check warning
Code scanning / CodeQL
File is not always closed
WeiqunZhang
force-pushed
the
speedup_clang-tidy
branch
from
06eff92
to
b5aae75
Compare
WeiqunZhang
force-pushed
the
speedup_clang-tidy
branch
7 times, most recently
from
7380f91
to
0e27100
Compare
We make ccache save a log file, from which we find out which files need a rebuild. Instead of running clang-tidy on every file, we now only run it on those files that had a miss in ccache. This significantly speeds up clang-tidy in CIs. Note that we treat clang-tidy warnings as errors in CIs. So if there is a hit in the ccache's cache, the file is free of clang-tidy warnings. Also note that we set CCACHE_EXTRAFILES to the clang-tidy configuration file. So any changes to the config file will invalidate the cache as it should. If a CI job successfully passes the compilation stage with ccache enabled, but fails at the clang-tidy stage, the ccache's cache has been updated. One might think this will cause issues because we now have files that have been cached by ccache and meanwhile have failed the clang-tidy checks. However, this is not an issue for Github CIs. This is because ccache's cache will not be saved as a Github cache, if a CI fails. Fix various clang-tidy warnings in Tests/. They were not reported before because clang-tidy was not used on the tests.
WeiqunZhang
force-pushed
the
speedup_clang-tidy
branch
from
0e27100
to
283b5de
Compare
|
I turned off EB in a 1D test, because we do not support EB in 1D. |
atmyers
approved these changes
Mar 30, 2023
1 task
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Jul 13, 2023
We make ccache save a log file, from which we find out which files need a rebuild. Instead of running clang-tidy on every file, we now only run it on those files that had a miss in ccache. This significantly speeds up clang-tidy in CIs. Note that we treat clang-tidy warnings as errors in CIs. So if there is a hit in the ccache's cache, the file is free of clang-tidy warnings. Also note that we set CCACHE_EXTRAFILES to the clang-tidy configuration file. So any changes to the config file will invalidate the cache as it should. If a CI job successfully passes the compilation stage with ccache enabled, but fails at the clang-tidy stage, the ccache's cache has been updated. One might think this will cause issues because we now have files that have been cached by ccache and meanwhile have failed the clang-tidy checks. However, this is not an issue for Github CIs. This is because ccache's cache will not be saved as a Github cache, if a CI fails. Fix various clang-tidy warnings in Tests/. They were not reported before because clang-tidy was not used on the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make ccache save a log file, from which we find out which files need a
rebuild. Instead of running clang-tidy on every file, we now only run it on
those files that had a miss in ccache. This significantly speeds up
clang-tidy in CIs.
Note that we treat clang-tidy warnings as errors in CIs. So if there is a
hit in the ccache's cache, the file is free of clang-tidy warnings. Also
note that we set CCACHE_EXTRAFILES to the clang-tidy configuration file. So
any changes to the config file will invalidate the cache as it should.
If a CI job successfully passes the compilation stage with ccache enabled,
but fails at the clang-tidy stage, the ccache's cache has been updated. One
might think this will cause issues because we now have files that have been
cached by ccache and meanwhile have failed the clang-tidy checks. However,
this is not an issue for Github CIs. This is because ccache's cache will not
be saved as a Github cache, if a CI fails.
Fix various clang-tidy warnings in Tests/. They were not reported before
because clang-tidy was not used on the tests.