Ensure that particles are always < rhi after applying periodic bcs. #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
approved these changes
Apr 20, 2023
jmsexton03
approved these changes
Apr 20, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Jul 13, 2023
…MReX-Codes#3263) We either need to iterate or just fix it this way, which is symmetric with the way rlo is handled. This relies on `rhi` being the largest point that is *inside* the domain, which is consistent with the ASSERT below. The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We either need to iterate or just fix it this way, which is symmetric with the way rlo is handled. This relies on
rhibeing the largest point that is inside the domain, which is consistent with the ASSERT below.The proposed changes: