ParticleInit: Implicit Int Float Conversion #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ICX warning: ``` implicit conversion from 'int' to 'amrex::Real' (aka 'float') changes value from 2147483647 to 2147483648 [-Wimplicit-const-int-float-conversion] ```
ax3l
commented
May 9, 2023
atmyers
approved these changes
May 9, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Jul 13, 2023
## Summary Fix ICX warning: ``` implicit conversion from 'int' to 'amrex::Real' (aka 'float') changes value from 2147483647 to 2147483648 [-Wimplicit-const-int-float-conversion] ``` ## Additional background First seen in ECP-WarpX/impactx#318 during built of pyAMReX. ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix ICX warning:
Additional background
First seen in ECP-WarpX/impactx#318 during built of pyAMReX.
Checklist
The proposed changes: