Coverity Scan

[WeiqunZhang]

Summary

Fix issues found by Coverity Scan, including infinite loop bugs in the kernels of MLALaplacian.

The scan will be done nightly on a local workstation.

Add coverity scan and license badges to README.md. Remove the cmake README.md because it's broken.

Checklist

The proposed changes:

• fix a bug or incorrect behavior in AMReX
• add new capabilities to AMReX
• changes answers in the test suite to more than roundoff level
• are likely to significantly affect the results of downstream AMReX users
• include documentation in the code and/or rst files, if appropriate

[ax3l]

Looks great 👍

[ax3l]

We can add this also to CMake, but if your build logic on Coverity is GNUmake only then this is fine, too.

[ax3l]

@WeiqunZhang just for sake of documentation, where did you implement the nightly sync-to-the-coverity-branch logic?

[WeiqunZhang]

I have a cron job running on this. We can only run 3 scans per day on average.

export PATH=$HOME/opt/cov-analysis/bin:$PATH

cd $HOME/coverity/amrex
git pull

rm -rf cov-int amrex.tgz

make distclean

./configure --with-mpi yes \
            --with-omp no \
            --with-fortran no \
            --enable-fortran-api no \
            --enable-eb yes \
            --enable-linear-solver yes \
            --enable-particle yes \
            --enable-tiny-profile yes

cov-build --dir cov-int make -j4 CXX=g++ USE_ASSERTION=TRUE USE_COVERITY=TRUE

tar cvfz amrex.tgz cov-int

AMREX_VERSION=$(git describe --abbrev=12 --dirty --always --tags)

curl --form token=${TOKEN} \
  --form email=weiqunzhang@lbl.gov \
  --form file=@amrex.tgz \
  --form version="AMReX-${AMREX_VERSION}" \
  --form description="AMReX" \
  https://scan.coverity.com/builds?project=AMReX-Codes%2Famrex

[ax3l]

Ah I see, got it.

In the past, I merged to a branch, which kicked off the upload via a plugin. Curling works as well.

If you like, you can also define cron-jobs in GH actions instead of locally: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

[WeiqunZhang]

Good suggestion. We could do it.

[WeiqunZhang]

But then we have to download the coverity tools everytime.

[WeiqunZhang]

The tarball is quite big. More than 1 GB.

[ax3l]

Oh, I see. Yeah, it's on the size of the CUDA toolkit or oneAPI then 😅