Fix typo in MLMGT<MF>::getGradSolution when MF is different from AMF
#3631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing the bug! Could you merge development into this so that the Intel CIs can pass? Could you also use |
|
You're welcome, and will do. 😀 |
…to MLMG-getGradSolution-possible-typo
WeiqunZhang
approved these changes
Nov 16, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
…`AMF` (AMReX-Codes#3631) ## Summary This PR fixes a small typo in `MLMGT<MF>::getGradSolution` that causes an error when `AMR` is distinct from `MF`. A test demonstrating the fix is added for the case where `MF`=`MultiFab` and `AMF`=`fMultiFab`. ## Additional background This typo was noticed when working on generalizing the `MLMG` template to the WIP class `FabArraySet`. ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a small typo in
MLMGT<MF>::getGradSolutionthat causes an error whenAMRis distinct fromMF. A test demonstrating the fix is added for the case whereMF=MultiFabandAMF=iMultiFab.Additional background
This typo was noticed when working on generalizing the
MLMGtemplate to the WIP classFabArraySet.Checklist
The proposed changes: