solve_bicgstab: use fewer MFs #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to solve_bicgstab-cut-ph-and-sh
…to solve_bicgstab-use-fewer-MFs
…to solve_bicgstab-use-fewer-MFs
WeiqunZhang
approved these changes
Nov 20, 2023
guj
pushed a commit
to guj/amrex
that referenced
this pull request
Dec 13, 2023
## Summary This PR cuts the number of MFs used in `solve_bicgstab`, saving on memory and LocalCopy operations. In particular, the MFs `ph` and `sh` are removed. ## Additional background This is a follow up to avoid-use-of-s and other PRs to improve `solve_bicgstab`. My own testing has shown that this PR gives the same results as before, but regression testing should be done to verify this in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cuts the number of MFs used in
solve_bicgstab, saving on memory and LocalCopy operations. In particular, the MFsphandshare removed.Additional background
This is a follow up to avoid-use-of-s and other PRs to improve
solve_bicgstab. My own testing has shown that this PR gives the same results as before, but regression testing should be done to verify this in all cases.