Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Ascent + Conduit #3639

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Nov 20, 2023

Summary

For some reason, AMReX_ASCENT does not trigger AMReX_CONDUIT to be set, too.

cc @cyrush

Additional background

X-ref: #3350

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

For some reason, `AMReX_ASCENT` does not trigger `AMReX_CONDUIT`
to be set, too.
@ax3l ax3l added the test label Nov 20, 2023
@ax3l ax3l mentioned this pull request Nov 20, 2023
5 tasks
@WeiqunZhang WeiqunZhang merged commit c51e0a3 into AMReX-Codes:development Nov 20, 2023
69 checks passed
@ax3l ax3l deleted the fix-ci-conduit branch November 20, 2023 23:21
@cyrush
Copy link
Contributor

cyrush commented Nov 27, 2023

thanks for making this fix.

guj pushed a commit to guj/amrex that referenced this pull request Dec 13, 2023
## Summary

For some reason, `AMReX_ASCENT` does not trigger `AMReX_CONDUIT` to be
set, too.

cc @cyrush 

## Additional background

X-ref: AMReX-Codes#3350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants