Additional SGS Models

[JhonCordova]

The WALE and Vreman models were integrated into the PeleC based on the rationale behind the original implementation of the Smagorinsky model available in this solver. Note that I have tried to encapsulate part of the code used in the 'getSmagorinskyLESTerm' method. Therefore, if there are any alternative suggestions, I am open to new ideas.

[marchdf]

You can remove all the files in refdata most likely. We don't need extra copies of those.

[marchdf]

Thank you for doing this! We will take a look at it this week. If you want to get the CI to start passing, you will need to do some formatting using clang-format.

[JhonCordova]

Thank you for the feedback. I will address the comments shortly.

[baperry2]

Thanks for doing this, and sorry it's taken a while for us to review.

It looks like the HIT_LES case is just a copy of the HIT case, except the input file. Is that right? If so, you can just put a hit-les.inp input file in the HIT case to avoid duplication of all those files. If you do that, I'll add it to the testing suite to ensure that the new LES models do not break in the future.

Have you run some tests with the WALE/Vremen models, particularly in comparison to Smagorinsky? If so, posting plots of the results here would be helpful.

[JhonCordova]

Thanks for doing this, and sorry it's taken a while for us to review.

It looks like the HIT_LES case is just a copy of the HIT case, except the input file. Is that right? If so, you can just put a hit-les.inp input file in the HIT case to avoid duplication of all those files. If you do that, I'll add it to the testing suite to ensure that the new LES models do not break in the future.

Have you run some tests with the WALE/Vremen models, particularly in comparison to Smagorinsky? If so, posting plots of the results here would be helpful.

Thanks for the feedback!

1. HIT_LES Case Update:
I've removed the HIT_LES case and included the hit-les.inp input file in the HIT case. This should streamline the process and avoid any unnecessary duplication of files.

2. SGS Models Comparison:
I have conducted tests comparing the WALE and Vreman models to the Smagorinsky model. The results and detailed analysis are presented in my publication, which you can access here.

Let me know if there's anything else you need or if further testing is required.

[marchdf]

@JhonCordova thanks for bearing with us as we wrangle this in. We really appreciate you contributing to the code and making it better. Good work!

[baperry2]

@JhonCordova I have added the hit-les case with WALE to run in the CI tests. I also took the liberty of making some changes to resolve warnings, so I think all tests should pass now. Thanks for posting the link to your paper, that will be a good reference for anyone using the newly implemented models.