Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug for isothermal EB on GPU #240

Merged
merged 2 commits into from
Sep 8, 2023
Merged

Fix bug for isothermal EB on GPU #240

merged 2 commits into from
Sep 8, 2023

Conversation

baperry2
Copy link
Collaborator

@baperry2 baperry2 commented Sep 7, 2023

Closes #237

@taaresh1 can you verify that this solves your problem?

@taaresh1
Copy link

taaresh1 commented Sep 7, 2023

@baperry2 This resolved the issue! Thanks a lot for the prompt response.

hsitaram
hsitaram approved these changes Sep 8, 2023
View reviewed changes
Copy link

@hsitaram hsitaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred to use const auto dx = Geom(lev).CellSizeArray(); instead of const Real* dx = Geom(lev).CellSize(); which is safe inside parallelfors

Thank you @baperry2 and @taaresh1 for fixing this issue

@baperry2 baperry2 merged commit a7364cb into AMReX-Combustion:development Sep 8, 2023
23 checks passed
@baperry2 baperry2 deleted the fix-gpu-isothermal-eb branch September 8, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsitaram hsitaram hsitaram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

peleLM.isothermal_EB = 1 causes CUDA error 700 - illegal memory access was encountered !!!
3 participants
@baperry2 @taaresh1 @hsitaram