auto-detect native CUDA arch #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
casperdcl
commented
May 21, 2023
casperdcl
commented
- auto-detect native CUDA arch (as per SWIG support #30 (comment))
- temporary work-around for https://gitlab.kitware.com/cmake/cmake/-/issues/24921
Merged
casperdcl
commented
May 21, 2023
| try: | ||
| from miutil import cuinfo | ||
| nvcc_arch_raw = map(cuinfo.compute_capability, range(cuinfo.num_devices())) | ||
| nvcc_arches = {"%d%d" % i for i in nvcc_arch_raw if i >= (3, 5)} |
There was a problem hiding this comment.
this error-prone hack (hardcoding min compute capability 3.5 rather than using proper tables123) is required due to https://gitlab.kitware.com/cmake/cmake/-/issues/24921
Footnotes
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 182 182
=========================================
Hits 182 182 ☔ View full report in Codecov by Sentry. |
casperdcl
force-pushed
the
auto-arch
branch
2 times, most recently
from
3354fda
to
a133446
Compare
casperdcl
commented
May 21, 2023
Comment on lines
+30
to
+33
| # work-around for https://gitlab.kitware.com/cmake/cmake/-/issues/24921 to | ||
| # detect local GPU architectures | ||
| # (inspired by ${CMAKE_ROOT}/Modules/CMakeTestCUDACompiler.cmake) | ||
| message(WARNING "overriding CMAKE_CUDA_ARCHITECTURES") |
There was a problem hiding this comment.
not guaranteed to always exist:
${CMAKE_ROOT}/Modules/CMakeTestCUDACompiler.cmake${CMAKE_ROOT}/Modules/CMakeDetermineCompilerABI.cmake${CMAKE_CUDA_ARCHITECTURES_ALL}
also overriding potentially user-specified CMAKE_CUDA_ARCHITECTURES isn't ideal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.