Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add support for an EOF callback #80

Open
lfarrel6 opened this issue Aug 29, 2022 · 4 comments
Open

Feature Request: add support for an EOF callback #80

lfarrel6 opened this issue Aug 29, 2022 · 4 comments
Assignees
Labels
A-output Output displayed E-feature Feature request I-api Internal API change O-dynamic Dynamic output X-api-add Addition to the external api; No risk of downstream breakage

Comments

@lfarrel6
Copy link

Feature description

I'd like to use minus to display paginated data that is pulled from an API. Ideally, the data would be paginated as the user scrolls through the logs, in a similar manner to an infinite scroll component.

Proposed Solution

An additional config on the PagerState, similar to the exit callback vectors. The callback should be fired when the user reaches the end of the currently available data.

Alternative

There's no clear alternative — while minus supports streaming data in, there's no obvious way to fetch more data at the rate that the user is consuming.

I am happy to contribute the changes to include this in the library.

@AMythicDev AMythicDev added O-dynamic Dynamic output A-output Output displayed I-api Internal API change X-api-add Addition to the external api; No risk of downstream breakage E-feature Feature request labels Aug 29, 2022
@AMythicDev
Copy link
Owner

Thanks for filling the feature request.

Currently I am busy incorporating a native user input declaration system inside ninus so it might take a while for me to work on this. If you want to help, you're are very welcome to file a PR.

For any help, join our Matrix or Discord rooms. Thanks again.

@lfarrel6
Copy link
Author

Happy to contribute 😄 I'll reference this issue in the PR

lfarrel6 added a commit to lfarrel6/minus that referenced this issue Aug 29, 2022
@AMythicDev
Copy link
Owner

Hey I just wanted to ping you whether you are ready with your PR for this issue. I am planning for a small release so if your PR is ready I will include it in the the release.

@AMythicDev AMythicDev assigned AMythicDev and lfarrel6 and unassigned AMythicDev Sep 17, 2022
@lfarrel6
Copy link
Author

Sorry, haven't gotten around to wrapping up the PR. Will hopefully get to it in the next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-output Output displayed E-feature Feature request I-api Internal API change O-dynamic Dynamic output X-api-add Addition to the external api; No risk of downstream breakage
Projects
Status: Todo ✔️
Development

No branches or pull requests

2 participants