Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Login Details to be stored in Secure PreferenceStore #9

Closed
cmalai opened this issue Jul 16, 2013 · 1 comment
Closed

GitHub Login Details to be stored in Secure PreferenceStore #9

cmalai opened this issue Jul 16, 2013 · 1 comment
Assignees
@subramanyamcs

Comments

@cmalai
Copy link
Member

cmalai commented Jul 16, 2013

Currently for PullRequest, we keep prompting for UserName and Password. It would be better to store the UserName and Password in SecurePreferenceStore.

Anyways this UserName and Password would be required across our utility for creating a GithubClient as and when required.
@ghost ghost assigned subramanyamcs Jul 16, 2013
@cmalai cmalai mentioned this issue Jul 18, 2013
Closed
@cmalai
Copy link
Member Author

cmalai commented Jul 19, 2013

Fixed : Secure Preference Store is used to store the UserName and Password of GitHub Account.
1st Time if the user uses the PullRequest functionality, he would be prompted to Login and has an option to Store the UserName and Password into PreferenceStore. Otherwise can open Windows > Preference Store to set his Username and Password.

@cmalai cmalai closed this as completed Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subramanyamcs subramanyamcs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmalai @subramanyamcs