Quick refactor of layouts/dashboard/index.js #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another quick PR, this one just applies a few small improvements to the
dashboard/index.js
file, to remove some unnecessary code, make it a tiny be more performant, and to neaten up a few things.Summary of changes:
sortCardsByDate
function, I parsed the date and just sorted numerically to avoid an extra operationtagsToString
function was simplified using joingenerateCards
function to first sort the projects, then filter them, and finally map them to JSX elementsfilterProjectsByQuery
andgenerateCardElement
are called properly ingenerateCards
generateCards
in the Dashboard component with the necessary argumentsI couldn't find the tests, so u might want to double check it works as you expect before merging ;)