Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: values assignment for the input signals #88

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

gcroci2
Copy link
Contributor

@gcroci2 gcroci2 commented May 2, 2024

I just noticed that PR #40 broke the assignment of the value for the input signals. In particular, the input signal needs to be set to 0 both if the modality is 'X' and if the modality is not the same as the one indicated in the sequence (e.g., the sequence has 'v', but the input signal we're building up is 'a').

Copy link
Collaborator

@DaniBodor DaniBodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Is there a way to add a test to prevent this mistake from slipping back in in the future?

I have a minor readability suggestion, but it is also fine as you wrote it if you prefer.

annubes/task.py Outdated Show resolved Hide resolved
@gcroci2
Copy link
Contributor Author

gcroci2 commented May 10, 2024

Good catch! Is there a way to add a test to prevent this mistake from slipping back in in the future?

Good point, I added a test for that :)

Copy link

sonarcloud bot commented May 10, 2024

@gcroci2 gcroci2 merged commit 0dc7c68 into main May 10, 2024
10 of 12 checks passed
@gcroci2 gcroci2 deleted the fix_build_trials_inputs branch May 10, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants