-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide generic helper functions to turn Coq terms into ocaml values and vice versa #9
Conversation
lthms
commented
Mar 6, 2019
•
edited
Loading
edited
- Support ascii (char) [prior to this PR]
- Support string (string) [prior to this PR]
- Partial support Z (int)
- Support bool (bool)
Until What do you think? |
I guess that bounded signed/unsigned integers are indeed the adequate types to interact with OCaml-level integers. Now, to develop certified applications, I would prefer arbitrary precision arithmetic if possible to avoid overflow-related bugs. The two kinds of integers should probably coexist in a the library. |
Since Vincent will need to work with Z, I propose to merge that PR as-is (if you could just have a quick look, @yurug, that would be awesome). Vincent will have to write the conversion from Ocaml to Coq, but it can be a good exercise. |
Nothing significant to say. You can merge this even if some refactoring might be needed at some point to make explicit good combinators for deconstruction of Coq values. |
Thanks. I will rework it a bit to address your comments, and then merge it. Thanks your the review! You can tell Vincent this will be ready this afternoon. |