Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When "send" feature is enabled, make Readers Send too #189

Merged
merged 3 commits into from Jan 22, 2024
Merged

Conversation

commial
Copy link
Contributor

@commial commial commented Jan 11, 2024

Mimic the behavior of the ArchiveWriter for ArchiveReader when the "send" feature is enabled.

As a result, when the feature "send" is enabled, ArchiveReader is now Send

@ANSSI-FR ANSSI-FR deleted a comment from github-actions bot Jan 22, 2024
@ANSSI-FR ANSSI-FR deleted a comment from github-actions bot Jan 22, 2024
@ANSSI-FR ANSSI-FR deleted a comment from github-actions bot Jan 22, 2024
@commial
Copy link
Contributor Author

commial commented Jan 22, 2024

Due to feature unification, when compiling the workspace with cargo --all-features, mla is compiled with the feature Send and, as a result, the mlar's mla dependency is also compiled with these feature (even if not actually requiring it).

In order to keep a cargo build --all-features working in the root workspace, the API used by mlar is updated. This should not be a break of SemVer, as the API is still compatible (if mlar was built inside its own workspace, this problem will not raise).

Finally, as the InnerLayerReaderTrait is not pub in the current crates.io version, the cargo publish fail. This is an expected behavior until a new mla release is made.

@commial commial merged commit defb19f into master Jan 22, 2024
23 of 24 checks passed
@commial commial deleted the reader-send branch January 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant