Skip to content

diode-receive: refactor reblock; add flag reblock_retention_window (#8) #120

diode-receive: refactor reblock; add flag reblock_retention_window (#8)

diode-receive: refactor reblock; add flag reblock_retention_window (#8) #120

Triggered via push February 5, 2024 07:11
Status Failure
Total duration 28s
Artifacts

clippy.yml

on: push
clippy-check
19s
clippy-check
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 2 warnings
unneeded `return` statement: src/receive/reblock.rs#L48
error: unneeded `return` statement --> src/receive/reblock.rs:48:9 | 48 | return value <= upper_bound || lower_bound <= value; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 48 - return value <= upper_bound || lower_bound <= value; 48 + value <= upper_bound || lower_bound <= value |
unneeded `return` statement: src/receive/reblock.rs#L45
error: unneeded `return` statement --> src/receive/reblock.rs:45:9 | 45 | return lower_bound <= value && value <= upper_bound; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 45 - return lower_bound <= value && value <= upper_bound; 45 + lower_bound <= value && value <= upper_bound |
unneeded `return` statement: src/receive/reblock.rs#L30
error: unneeded `return` statement --> src/receive/reblock.rs:30:5 | 30 | / return is_in_wrapped_interval( 31 | | block_id, 32 | | ( 33 | | leading_block_id.wrapping_sub(window_size - 1), 34 | | leading_block_id, 35 | | ), 36 | | ); | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 30 ~ is_in_wrapped_interval( 31 + block_id, 32 + ( 33 + leading_block_id.wrapping_sub(window_size - 1), 34 + leading_block_id, 35 + ), 36 ~ ) |
unneeded `return` statement: src/receive/reblock.rs#L23
error: unneeded `return` statement --> src/receive/reblock.rs:23:9 | 23 | return retain; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 23 - return retain; 23 + retain |
clippy-check
Clippy had exited with the 101 exit code
clippy-check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy-check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/