Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow smoothing to be specified in mm or vox #1350

Merged
merged 1 commit into from
May 4, 2022

Conversation

cookpa
Copy link
Member

@cookpa cookpa commented May 4, 2022

Previously, affine transforms used the registration method default (mm) while deformable transforms used voxels.

Made them consistent with antsRegistration, allowing AxBxCmm or AxBxCvox specification.

Previously, affine transforms used the registration method default (mm)
while deformable transforms were hard-coded to voxels.
@cookpa cookpa merged commit e9c4cc0 into master May 4, 2022
@cookpa
Copy link
Member Author

cookpa commented May 4, 2022

This is for antsMotionCorr, I probably should have clarified in the comment

@gdevenyi
Copy link
Contributor

gdevenyi commented May 4, 2022

To clarify, this means antsMotionCorr smoothing options were in mm unless otherwise specified, which is opposite to antsRegistration?

     -s, --smoothing-sigmas MxNxO...
          Specify the sigma of gaussian smoothing at each level. Units are given in terms 
          of voxels ('vox') or physical spacing ('mm'). Example usage is '4x2x1mm' and 
          '4x2x1vox' where no units implies voxel spacing. 

Will the default remain mm?

@cookpa
Copy link
Member Author

cookpa commented May 4, 2022

The default is now voxels, consistent with antsRegistration. It was inconsistent before in the code, an affine transform specified smoothing in mm, and SyN smoothing was in voxels.

A default of mm is more backwards compatible for most use cases, but then we're committing to being different from antsRegistration, which is its own problem.

@hjmjohnson hjmjohnson deleted the antsMotionCorrSmooth branch May 12, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants