WIP: Changes for updating to current ITK. #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ntustison - I think this was also done in the draft #1331 , which also incorporates an ITK bump. Just noting for future merge conflict management |
|
Good to know. Thanks. |
|
I'd like to see the tag updated to at least InsightSoftwareConsortium/ITK@5ce861b to integrate some some fixes for the sform transition, which has been causing problems in rodent and high-res human datasets. |
|
Following up here, can we bump to a later snapshot to pull in the isAffine for small voxes and merge this? |
|
@gdevenyi --- that sounds good to me. Do you want to put together the necessary changes for merging? |
|
Sure, I'll cherry pick this and update the ITK snapshot and see if anything else shakes out. |
|
Superceeded by #1382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current ITK clone seems to include some changes to the enumerated types for spatial orientation.
Putting this here for when we update ITK.