Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Use docker to build Centos binaries #1393

Merged
merged 2 commits into from
Jul 14, 2022
Merged

ENH: Use docker to build Centos binaries #1393

merged 2 commits into from
Jul 14, 2022

Conversation

cookpa
Copy link
Member

@cookpa cookpa commented Jul 14, 2022

This can be extended to other platforms that aren't supported by native runners.

Also made some improvements for readability to the native release binary build

Swapped out the artifact uploader to one that retries if there's a network error

This can be extended to other platforms

Also made some improvements for readability to the native release binary build

Swapped out the artifact uploader to one that retries if there's a network error
@cookpa
Copy link
Member Author

cookpa commented Jul 14, 2022

To do: Include architecture in binary names.

@cookpa cookpa marked this pull request as ready for review July 14, 2022 18:12
@cookpa
Copy link
Member Author

cookpa commented Jul 14, 2022

I made a bunch of changes to do things better, added more targets so we pretty much build on all supported Mac and Linux runners now.

Linux runners are all Ubuntu, but using Docker, I was able to build inside Centos 7. We can add other targets the same way, as long as they build in time. The Centos build is slightly slower because the runner crashes out of memory with a parallel build, but it's well under the six hour limit.

@cookpa cookpa merged commit 04a018d into master Jul 14, 2022
@cookpa cookpa deleted the releaseBinaries branch July 14, 2022 19:41
@cookpa cookpa mentioned this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant