Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add spacing option for laplacian sharpening. #1543

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

ntustison
Copy link
Member

@ntustison ntustison commented May 23, 2023

Add option to sharpen without using the image spacing. Explicitly turn off in template building. Addresses #1540.

@ntustison
Copy link
Member Author

I'm guessing this is a false positive, unfortunately. m_UseImageSpacing seems to not even be used in the itkLaplacianSharpeningImageFilter. Pausing on this until I figure out more.

@ntustison ntustison merged commit d62539d into master Jul 4, 2023
1 check passed
@ntustison ntustison deleted the SharpenWithoutSpacing branch July 4, 2023 03:49
@gdevenyi
Copy link
Contributor

gdevenyi commented Jul 4, 2023

Weren't there some ITK changes done as well requiring a bump in the ITK commit for the superbuild?

@ntustison
Copy link
Member Author

Yes, I'm sure we'll bring in those changes at some point, and you're welcome to do so, but this pull commit doesn't change any current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants