Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update password_encryption for PostgreSQL 10 #368

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

MiLk
Copy link
Contributor

@MiLk MiLk commented Jul 15, 2018

With PostgreSQL 10, password_encryption is no longer a boolean.
It expects either md5 or scram-sha-256.
The value on is kept as an alias of md5 for backward compatibility.

With PostgreSQL 10, `password_encryption` is no longer a boolean.
It expects either `md5` or `scram-sha-256`.
The value `on` is kept as an alias of `md5` for backward compatibility.
@acrewdson
Copy link

Thanks @MiLk. Hoping this can be merged soon, since this role doesn't currently seem to work with Ansible 2.4.x when specifying PG 10.

@bbomgardner
Copy link

Ran into this today also. ETA on merge?

@gclough
Copy link
Collaborator

gclough commented Oct 10, 2018

Based on the documentation, "on/off" is still valid syntax... but the current code effectively prevents scram-sha-256 from being used, so this should be fixed:

https://www.postgresql.org/docs/10/static/runtime-config-connection.html#GUC-PASSWORD-ENCRYPTION

Do we also need to update the default variables?

@MiLk
Copy link
Contributor Author

MiLk commented Oct 11, 2018

The default value in postgres being md5, I think it's ok to keep on in the role as they have the same meaning.

@lrk
Copy link
Contributor

lrk commented Jan 21, 2020

@MrMoins @gclough any update on that PR ?

skress added a commit to skress/ansible-postgresql that referenced this pull request May 25, 2020
@egmont1227
Copy link
Contributor

duplicated by #460, i propose to close this one

egmont1227 pushed a commit to noris-network/ansible-postgresql that referenced this pull request May 28, 2020
@gclough gclough merged commit 0eff79e into ANXS:master Feb 10, 2021
@gclough
Copy link
Collaborator

gclough commented Feb 10, 2021

I'll merge this one, and then #460 , to give credit as necessary.

robustq pushed a commit to robustq/postgresql that referenced this pull request Feb 25, 2021
Update password_encryption for PostgreSQL 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants