Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sync standby names to include choose keyword #462

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Update sync standby names to include choose keyword #462

merged 1 commit into from
Mar 6, 2020

Conversation

UmanShahzad
Copy link
Contributor

@UmanShahzad UmanShahzad commented Jan 10, 2020

In this file (I haven't checked all the others, except pg-10), the choose_sync var wasn't being specified.

This copies the logic to render the string from the pg-10 template.

Docs: https://www.postgresql.org/docs/12/runtime-config-replication.html#GUC-SYNCHRONOUS-STANDBY-NAMES

Copy link
Collaborator

@gclough gclough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. This parameter change was introduced in v10, and is correctly in the template for that version. Your patch currently fixes v12, but has missed v11. Could you make the same change in v11, and then I can merge it?

templates/postgresql.conf-12.j2 Show resolved Hide resolved
This copies the logic to render the string from the pg-10 template.
@UmanShahzad
Copy link
Contributor Author

@gclough We never merged this!

@gclough gclough merged commit d8fc0d3 into ANXS:master Mar 6, 2020
@UmanShahzad UmanShahzad deleted the patch-1 branch March 6, 2020 16:35
robustq pushed a commit to robustq/postgresql that referenced this pull request Feb 25, 2021
Update sync standby names to include choose keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants