Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question # Tests Compiled Wrong #256

Open
tuzhiming2016 opened this issue Aug 29, 2020 · 2 comments
Open

Question # Tests Compiled Wrong #256

tuzhiming2016 opened this issue Aug 29, 2020 · 2 comments

Comments

@tuzhiming2016
Copy link

I found that the three files have some problem.
CubicConvolutionInterpolationTest.cpp
CubicInterpolationTest.cpp
EigenPluginsTest.cpp

first:
in the file #include "grid_map_core/TypeDefs.hpp"
enum class InterpolationMethods has no member called INTER_CUBIC and INTER_CUBIC_CONVOLUTION.
Are these your TODOs? So The two tests may have some wrongs if compiled?
TODOs{gm::InterpolationMethods::INTER_CUBIC
gm::InterpolationMethods::INTER_CUBIC_CONVOLUTION}????

second:
in the file EigenPluginsTest.cpp
Eigen::Matrix has no member named ‘numberOfFinites’ as well as sumOfFinites minCoeffOfFinites and maxCoeffOfFinites.
I found that the definition is in grid_map_core/eigen_plugins/DenseBasePlugin.hpp, however there is no one file include that, and there would be wrong if compiled.
Is this also your TODO??

Or if not , Can you give me some solutions to that? And I am using the package.
Thanks a lot~

TuZhiming

@maximilianwulf
Copy link
Collaborator

Hey @tuzhiming2016, it looks like you found some issues in our tests. Could you submit a PR to solve those?

@tcjcxy30
Copy link

Hi @tuzhiming2016 :
I have found this problem too. Do you know how to fix it now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants