Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define semantics of avio brand for image items #114

Merged
merged 15 commits into from Jan 6, 2021
Merged

Define semantics of avio brand for image items #114

merged 15 commits into from Jan 6, 2021

Conversation

cconcolato
Copy link
Collaborator

@cconcolato cconcolato commented Oct 23, 2020 •
edited by pr-preview bot

closes #105

Preview | Diff

@leo-barnes
Copy link
Collaborator

Is avio defined somewhere else except in the AVIF spec? I only see it mentioned with shoulds in AVIF. Don't we need to have a shall somewhere to say that it may not be used if the primary item/sequence contains predicted frames? Or maybe that's unnecessarily strict.

@cconcolato
Copy link
Collaborator Author

avio is only defined in AVIF. I agree to rephrase it with shalls.

leo-barnes
leo-barnes approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@leo-barnes leo-barnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

wantehchang
wantehchang approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for writing these changes.

index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated

Additionally, if the image sequences are made only of [=AV1 Samples=] marked as 'sync', then the brand <dfn value="" export="" for="AVIF Intra-only brand">avio</dfn> should be used.
Files that conform with these constraints should include in the [=compatible_brands=] field of the [=FileTypeBox=]:
- the brand <code>'[=avis=]'</code>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit/optional: If the major_brand field is "avis", it is not clear whether this sentence implies that "avis" should appear in the compatible_brands field again.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a common practice to replicate the major brand in the compatible brands, but I will double check the impact of not doing it.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@leo-barnes
Copy link
Collaborator

Per meeting, the conclusion was that we wanted the following changes:

  1. Infer avif from avis brand to keep down the header overhead.
  2. Remove or its alternates with regards to the primary item when using the avif brand.
  3. Remove usage of TrackTypeBox.

@wantehchang wantehchang mentioned this pull request Nov 20, 2020
Closed
wantehchang
wantehchang approved these changes Dec 9, 2020
View reviewed changes
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
leo-barnes
leo-barnes approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@leo-barnes leo-barnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cconcolato
Copy link
Collaborator Author

@wantehchang I think I addressed your last comments. Let me know otherwise.

wantehchang
wantehchang approved these changes Jan 6, 2021
View reviewed changes
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, Cyril.

@cconcolato cconcolato merged commit 9459ef4 into master Jan 6, 2021
@cconcolato cconcolato deleted the avio_item branch February 4, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-barnes leo-barnes leo-barnes approved these changes

@wantehchang wantehchang wantehchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify the use of 'avio' brand for multi-layer images
3 participants
@cconcolato @leo-barnes @wantehchang