Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the page numbers in links to the AV1 spec #174

Merged
merged 2 commits into from Sep 22, 2023

Conversation

wantehchang
Copy link
Collaborator

@wantehchang wantehchang commented Aug 7, 2023

Fix #135


Preview | Diff

text: Redundant Frame Header OBU

url: https://aomediacodec.github.io/av1-spec/av1-spec.pdf#page=121; spec: AV1; type: dfn;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page=121 part was apparently intended to point to Section 6.6 (Padding OBU semantics) in the AV1 spec. Since all the other xxx OBU links point to the Syntax rather than the Semantics sections, I fixed this page number by pointing to Section 5.7 (Padding OBU syntax).

@@ -65,13 +65,13 @@ url: https://aomediacodec.github.io/av1-spec/av1-spec.pdf#page=121; spec: AV1; t
url: https://aomediacodec.github.io/av1-spec/av1-spec.pdf#page=46; spec: AV1; type: dfn;
text: Metadata OBU

url: https://aomediacodec.github.io/av1-spec/av1-spec.pdf#page=121; spec: AV1; type: dfn;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page=121 part seems simply wrong. I can't figure out which section of the spec it was intended to point to. I guess it was a copy-and-paste error (see line 71). I fixed this page number by pointing to Section 5.9 (Frame header OBU syntax). Note that Frame Header OBU and Redundant Frame Header OBU share the same syntax.

@wantehchang
Copy link
Collaborator Author

I just wanted to add that while writing this pull request, I checked both versions of the AV1 spec (in the PDF format), which can be downloaded from https://github.com/AOMediaCodec/av1-spec/releases.

@cconcolato cconcolato merged commit 2a2f394 into AOMediaCodec:main Sep 22, 2023
github-actions bot added a commit that referenced this pull request Sep 22, 2023
SHA: 2a2f394
Reason: push, by cconcolato

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wantehchang wantehchang deleted the fix-av1-spec-links branch September 22, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to AV1 spec need an page offset
2 participants