Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Sequence Header OBU in configOBUs. #47

Closed
wants to merge 1 commit into from
Closed

Require Sequence Header OBU in configOBUs. #47

wants to merge 1 commit into from

Conversation

tomfinegan
Copy link
Collaborator

Addresses #46

@tomfinegan
Copy link
Collaborator Author

There's some discussion in the issue. WDYT @cconcolato ?

@robUx4
Copy link

robUx4 commented Jul 28, 2018

That's a welcome improvement.
What happens if there's more than one of that kind ? In Matroska it must be the only OBU of that kind.
It must also be the first to make parsing of profiles easier.
I think these two requirements could be integrated as well.

@jamrial jamrial mentioned this pull request Jul 30, 2018
Closed
@tomfinegan tomfinegan closed this Aug 9, 2018
@tomfinegan tomfinegan deleted the configobus_must_contain_sh branch August 9, 2018 20:11
@tomfinegan tomfinegan mentioned this pull request Sep 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cconcolato cconcolato Awaiting requested review from cconcolato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomfinegan @robUx4