Handle out-of-memory errors, such as avifAlloc() failures #820

wantehchang · 2022-01-21T23:56:10Z

This issue tracks the work on handling out-of-memory errors, starting with avifAlloc() failures.

I will do this work in installments because this requires a lot of changes.

Add the AVIF_RESULT_OUT_OF_MEMORY error code. Add the avifArrayPop() function to remove the last element in the array. Bug: AOMediaCodec#820.

Add the AVIF_RESULT_OUT_OF_MEMORY error code. Add the avifArrayPop() function to remove the last element in the array. Bug: #820.

Fix a bug introduced in commit f732a4d. In avifEncoderDataCreateItem(), increment data->lastItemID before setting item->id equal to data->lastItemID. This is what the original code did. Bug: AOMediaCodec#820

Fix a bug introduced in commit f732a4d. In avifEncoderDataCreateItem(), increment data->lastItemID before setting item->id equal to data->lastItemID. This is what the original code did. Fix #836. Bug: #820

Allow avifDecoderDataCreateTile() to fail on avifImageCreateEmpty() or avifCodecDecodeInputCreate() failures. Note that we don't check for avifArrayPushPtr() failure yet. That will be done later. Change all avifDecoderDataCreateTile() callers to handle its failures. Bug: AOMediaCodec#820

Allow avifDecoderDataCreateTile() to fail on avifImageCreateEmpty() or avifCodecDecodeInputCreate() failures. Note that we don't check for avifArrayPushPtr() failure yet. That will be done later. Change all avifDecoderDataCreateTile() callers to handle its failures. Bug: #820

This is part of a series of changes to replace abort() by return null upon memory allocation failure in avifAlloc(). Bug: AOMediaCodec#820

This is part of a series of changes to replace abort() by return null upon memory allocation failure in avifAlloc(). Bug: #820

Also avifImageSetProfileICC(), avifImageSetMetadataExif(), avifImageSetMetadataXMP() and avifCodecEncodeOutputAddSample(). To catch out-of-memory issues. Bug: AOMediaCodec#820

Also avifImageSetProfileICC(), avifImageSetMetadataExif(), avifImageSetMetadataXMP() and avifCodecEncodeOutputAddSample(). To catch out-of-memory issues. Bug: #820

On memory allocation failure, the current behavior is to abort the process. We are working to change avifAlloc() to return NULL. See AOMediaCodec#820.

On memory allocation failure, the current behavior is to abort the process. We are working to change avifAlloc() to return NULL. See #820.

y-guyon · 2023-10-19T15:35:44Z

All avifAlloc() calls should be checked now.

vrabaud · 2023-10-20T13:19:31Z

I confirm all avifAlloc are checked.

wantehchang · 2023-10-20T14:37:45Z

Yannis: Thank you very much for all your work on this issue! This is an enormous amount of work and requires patience and perseverance.

I changed the assignee to you and removed myself. (The initial work I did is insignificant compared with what you have done.)

Does this mean we can remove the abort() call in avifAlloc() now?

y-guyon · 2023-10-20T15:48:42Z

Thanks.

Does this mean we can remove the abort() call in avifAlloc() now?

Yes. I was wondering if adding a test or fuzz target to exercise malloc() failures would be worth it. Maybe it can be done after the change.

y-guyon · 2023-10-20T16:07:42Z

Once the changes above are merged, the apps and src folders are handled.

There are a few allocations in third_party/libyuv (a small portion of code copied from upstream libyuv). These are not checked.
Unfortunately it also means using the whole libyuv library as a dependency is a liability. I filed https://bugs.chromium.org/p/libyuv/issues/detail?id=968.

I can imagine other dependencies such as libaom bringing the same risk. Should this bug be closed before all dependencies are safe?

wantehchang · 2023-10-20T17:49:53Z

I suggest closing this issue as completed and open a new issue about libyuv.

Unlike libyuv, libaom aims to handle memory allocation failures (see https://crbug.com/aomedia/3276), so it doesn't seem necessary to file a new issue about libaom.

wantehchang · 2023-10-20T17:52:25Z

Sorry, I forgot the code in third_party/libyuv. In my previous comment, I was referring to the upstream libyuv.

We can probably also open a new issue about the code in third_party/libyuv. Or we can leave this issue open until that code is fixed.

y-guyon · 2023-10-21T07:13:30Z

we can leave this issue open until that code is fixed.

I agree.

Unlike libyuv, libaom aims to handle memory allocation failures (see https://crbug.com/aomedia/3276), so it doesn't seem necessary to file a new issue about libaom.

Great. What about other dependencies, especially dav1d? I think libsharpyuv is fine too, right @vrabaud?

vrabaud · 2023-10-23T09:51:44Z

Indeed, fr libsharpyuv, allocs are only done in one spot and they are checked: https://chromium.googlesource.com/webm/libwebp/+/refs/heads/main/sharpyuv/sharpyuv.c#331

wantehchang · 2023-10-24T00:39:43Z

Yannis: I randomly inspected a few calls to dav1d_malloc() and dav1d_alloc_aligned() in dav1d. It's clear that dav1d handles memory allocation failures.

y-guyon · 2023-11-09T09:38:26Z

There are a few allocations in third_party/libyuv (a small portion of code copied from upstream libyuv). These are not checked.

Now that it is done, all core library places should be checked now.

wantehchang self-assigned this Jan 21, 2022

wantehchang added a commit to wantehchang/libavif that referenced this issue Jan 21, 2022

Handle avifArrayCreate() failures

20eaeaa

Add the AVIF_RESULT_OUT_OF_MEMORY error code. Add the avifArrayPop() function to remove the last element in the array. Bug: AOMediaCodec#820.

wantehchang mentioned this issue Jan 21, 2022

Handle avifArrayCreate() failures #821

Merged

wantehchang added a commit to wantehchang/libavif that referenced this issue Jan 26, 2022

Handle avifArrayCreate() failures

239c60a

Add the AVIF_RESULT_OUT_OF_MEMORY error code. Add the avifArrayPop() function to remove the last element in the array. Bug: AOMediaCodec#820.

wantehchang added a commit to wantehchang/libavif that referenced this issue Jan 26, 2022

Handle avifArrayCreate() failures

8f83d91

Add the AVIF_RESULT_OUT_OF_MEMORY error code. Add the avifArrayPop() function to remove the last element in the array. Bug: AOMediaCodec#820.

wantehchang added a commit to wantehchang/libavif that referenced this issue Jan 26, 2022

Handle avifArrayCreate() failures

3387153

Add the AVIF_RESULT_OUT_OF_MEMORY error code. Add the avifArrayPop() function to remove the last element in the array. Bug: AOMediaCodec#820.

wantehchang added a commit that referenced this issue Jan 27, 2022

Handle avifArrayCreate() failures

f732a4d

Add the AVIF_RESULT_OUT_OF_MEMORY error code. Add the avifArrayPop() function to remove the last element in the array. Bug: #820.

wantehchang mentioned this issue Jan 29, 2022

Increment lastItemID first when creating an item #835

Merged

wantehchang mentioned this issue Feb 14, 2022

Handle avifDecoderDataCreateTile() failures #844

Merged

y-guyon added a commit to y-guyon/libavif that referenced this issue Apr 5, 2022

Prepare avif example for non-aborting avifAlloc()

7116ae2

This is part of a series of changes to replace abort() by return null upon memory allocation failure in avifAlloc(). Bug: AOMediaCodec#820

y-guyon mentioned this issue Apr 5, 2022

Prepare avif example for non-aborting avifAlloc() #906

Merged

wantehchang pushed a commit that referenced this issue Apr 5, 2022

Prepare avif example for non-aborting avifAlloc() (#906)

cdb8ad3

This is part of a series of changes to replace abort() by return null upon memory allocation failure in avifAlloc(). Bug: #820

y-guyon mentioned this issue Dec 13, 2022

avifRGBImageAllocatePixels will crash #1250

Closed

y-guyon mentioned this issue Feb 7, 2023

Check OOM in avifImageCreate, avifEncoderCreate #1279

Merged

y-guyon mentioned this issue Mar 25, 2023

avifRGBImageAllocatePixels() returns avifResult #1309

Merged

y-guyon mentioned this issue Jul 26, 2023

avifRWDataRealloc,avifRWDataSet return avifResult #1478

Merged

y-guyon added a commit that referenced this issue Jul 31, 2023

avifRWDataRealloc,avifRWDataSet return avifResult

397f74c

Also avifImageSetProfileICC(), avifImageSetMetadataExif(), avifImageSetMetadataXMP() and avifCodecEncodeOutputAddSample(). To catch out-of-memory issues. Bug: #820

y-guyon mentioned this issue Aug 4, 2023

Propagate avifResult from stream.c makeRoom() #1498

Merged

wantehchang mentioned this issue Aug 23, 2023

Add a note about the OOM behavior of avifAlloc() #1511

Merged

wantehchang added a commit that referenced this issue Aug 23, 2023

Add a note about the OOM behavior of avifAlloc()

f1f3d92

On memory allocation failure, the current behavior is to abort the process. We are working to change avifAlloc() to return NULL. See #820.

This was referenced Oct 4, 2023

Handle out-of-memory failures in avifCodecCreate() #1651

Merged

Check avifAlloc() success in aomCodecEncodeImage() #1660

Merged

Check avifAlloc() in avifIOCreateMemoryReader() #1661

Merged

Check avifAlloc() in avifSampleTableCreate() #1662

Merged

y-guyon mentioned this issue Oct 6, 2023

Check avifAlloc() success in avifDecoderCreate() #1663

Merged

This was referenced Oct 17, 2023

Check avifAlloc() success in avmCodecEncodeImage() #1689

Merged

Check avifAlloc() in avifCodecEncodeOutputCreate() #1690

Merged

Check avifAlloc() result in avifArrayPush*() #1694

Merged

Check avifAlloc() in avifItemPropertyDedupCreate() #1697

Merged

wantehchang assigned y-guyon and unassigned wantehchang and y-guyon Oct 20, 2023

y-guyon mentioned this issue Oct 20, 2023

Remove abort() on avifAlloc() failure #1700

Merged

y-guyon mentioned this issue Oct 20, 2023

Handle memory allocation failures in apps #1701

Merged

This was referenced Nov 2, 2023

Sync third_party/libyuv to libyuv version 1879 #1722

Closed

Sync third_party/libyuv and propagate errors #1739

Merged

y-guyon closed this as completed Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle out-of-memory errors, such as avifAlloc() failures #820

Handle out-of-memory errors, such as avifAlloc() failures #820

wantehchang commented Jan 21, 2022

y-guyon commented Oct 19, 2023

vrabaud commented Oct 20, 2023

wantehchang commented Oct 20, 2023

y-guyon commented Oct 20, 2023

y-guyon commented Oct 20, 2023

wantehchang commented Oct 20, 2023

wantehchang commented Oct 20, 2023 •

edited

y-guyon commented Oct 21, 2023

vrabaud commented Oct 23, 2023

wantehchang commented Oct 24, 2023

y-guyon commented Nov 9, 2023

Handle out-of-memory errors, such as avifAlloc() failures #820

Handle out-of-memory errors, such as avifAlloc() failures #820

Comments

wantehchang commented Jan 21, 2022

y-guyon commented Oct 19, 2023

vrabaud commented Oct 20, 2023

wantehchang commented Oct 20, 2023

y-guyon commented Oct 20, 2023

y-guyon commented Oct 20, 2023

wantehchang commented Oct 20, 2023

wantehchang commented Oct 20, 2023 • edited

y-guyon commented Oct 21, 2023

vrabaud commented Oct 23, 2023

wantehchang commented Oct 24, 2023

y-guyon commented Nov 9, 2023

wantehchang commented Oct 20, 2023 •

edited