Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test gdk-pixbuf on TravisCI #296

Closed
wants to merge 2 commits into from
Closed

Test gdk-pixbuf on TravisCI #296

wants to merge 2 commits into from

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Aug 29, 2020

gdk-pixbuf isn't tested on CI yet but Arch, Fedora (separate), FreeBSD, Gentoo (USE), MSYS2 already expose it downstream. This PR only covers FreeBSD as I'm not familar with other systems.

FreeBSD by default only looks for headers/libraries in base system, so
depending on packages requires passing -isystem + -L or relying on pkg-config.

FAILED: contrib/gdk-pixbuf/libpixbufloader-avif.so
: && /usr/bin/cc -fPIC    -shared -Wl,-soname,libpixbufloader-avif.so -o contrib/gdk-pixbuf/libpixbufloader-avif.so contrib/gdk-pixbuf/CMakeFiles/pixbufloader-avif.dir/loader.c.o  -Wl,-rpath,/a/libavif/build:  -lgdk_pixbuf-2.0  -lgobject-2.0  -lglib-2.0  -lintl  libavif.so.6.0.0 && :
ld: error: unable to find library -lgdk_pixbuf-2.0
ld: error: unable to find library -lgobject-2.0
ld: error: unable to find library -lglib-2.0
ld: error: unable to find library -lintl
cc: error: linker command failed with exit code 1 (use -v to see invocation)
@joedrago
Copy link
Collaborator

I'm sorry, I won't be accepting this one.

The whole point of the contrib/ directory is to be an officially unsupported list of contributions. I was already hesitant to accept this file in the first place, but I figured it'd be a one-and-done type of simple file people could use as a reference or point to. This kind of change would cause the official libavif CI builds to fail on this file, which completely betrays the notion of the contrib directory.

This file has already seen way too much traffic. If it is becoming an important daily driver for people, perhaps @novomesk, @linkmauve , or @jbeich should make an official repo for gdk-pixbuf-avif and make libavif a git submodule in it, and I can remove it from the libavif repo entirely.

@joedrago joedrago closed this Aug 31, 2020
@novomesk
Copy link
Contributor

If we move the gdk-pixbuf loader to its own project, it will have very few users.

People would end up using gdk-pixbuf loader from libheif project instead which is officially supported there.

Being under shelter of libavif is a big advantage. The component is tested by more platforms and the bugs are discovered more quickly. libavif is becoming available on more and more platforms.

Right now (when we have support of transformations already), I consider the libpixbufloader-avif.so better for AVIF than gdk-pixbuf loader from libheif because we have save support too.

We can easily add animations support to the loader but can't do it right now with libheif one. I'd like to indicate there could be more commits in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants