Fix compilation with clang 13 #783
Conversation
CMakeLists.txt
Outdated
| @@ -128,6 +128,7 @@ if(CMAKE_C_COMPILER_ID MATCHES "Clang") | |||
| -Wno-padded | |||
| -Wno-sign-conversion | |||
| -Wno-error=c11-extensions | |||
| -Wno-reserved-identifier | |||
There was a problem hiding this comment.
The -Wno-reserved-identifier flag is not recognized by older versions of clang, such as clang 7.0.1 and 9.0.1. So this needs to be guarded by a feature detection test. I think we can model it after the HAVE_POISON_SYSTEM_DIRECTORIES_WARNING test:
// Some glib-2.0 headers use identifier names that start with '_' followed by a capital letter.
check_c_compiler_flag(-Wreserved-identifier HAVE_RESERVED_IDENTIFIER_WARNING)
if(HAVE_RESERVED_IDENTIFIER_WARNING)
add_definitions(-Wno-reserved-identifier)
endif()
I have three other comments.
-
/usr/include/ctype.h is part of the C implementation, so a C compiler should not warn that /usr/include/ctype.h uses reserved identifiers. This seems like a bug in clang 13. Indeed, I cannot reproduce the warnings about /usr/include/ctype.h with Clang 14.0.0 pre-release. I can, however, reproduce the warnings about glib-2.0 headers.
-
It would be good to disable the -Wreserved-identifier warning only for glib-2.0 headers.
-
This bug is an example of the problem with using clang's -Weverything flag: we are opting in to all the new compiler warning flags and it is a maintenance burden to update the -Wno-xxx list. It would be better to use -Wall -Wextra instead and add the other compiler warning flags that we find useful.
|
@wantehchang Thaks. Correct remarks. I updated pull request. |
CMakeLists.txt
Outdated
| @@ -129,6 +129,13 @@ if(CMAKE_C_COMPILER_ID MATCHES "Clang") | |||
| -Wno-sign-conversion | |||
| -Wno-error=c11-extensions | |||
| ) | |||
| # Some headers such as glib-2.0 use identifier names that start with '_' followed by a capital letter. | |||
| # The C standard reserves names beginning with an underscore and various other combinations. | |||
| # ISO/IEC 9899:1999 (aka C99 standard) §7.1.3 Reserved identifiers | |||
There was a problem hiding this comment.
Could you please change the '§' character to "Section" or "Sec."? We are trying to use only ASCII characters in the source code.
There was a problem hiding this comment.
Yep. I removed '§' character.
I think it will be better.
Some headers such as glib-2.0 use identifier names that start with '_' followed by a capital letter. The C standard reserves names beginning with an underscore and various other combinations. ISO/IEC 9899:1999 (aka C99 standard) 7.1.3 Reserved identifiers
|
I am very sorry that I forgot to merge this pull request. I will do that now. |
Fix this issue with clang 13 #782