Add iso8 to compatible_brands for animated images #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Section 10.3.1.1. of the HEIF spec: It is required that 'iso8' is present among the compatible brands array. Fixes the Compliance Warden error: [heif][Rule #31] Error: 'msf1' brand: 'iso8' shall be present among the compatible brands array
wantehchang
approved these changes
Feb 17, 2022
|
@cconcolato In the AVIF spec, should we add "iso8" after "msf1" in the examples? |
|
I'm not sure I like the explosion of brands but that ship has sailed ... The idea was that an And yes we should add it to the example in the spec. I created an issue AOMediaCodec/av1-avif#187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section 10.3.1.1. of the HEIF spec:
It is required that 'iso8' is present among the compatible brands array.
Fixes the Compliance Warden error:
[heif][Rule #31] Error: 'msf1' brand: 'iso8' shall be present among the compatible brands array