Skip to content

Commit

Permalink
abbs: mass rebuild for gnutls update
Browse files Browse the repository at this point in the history
  • Loading branch information
Mingcong Bai authored and Artoria2e5 committed Sep 13, 2015
1 parent 7640dce commit a3ec29d
Show file tree
Hide file tree
Showing 97 changed files with 1,229 additions and 40 deletions.
9 changes: 9 additions & 0 deletions BROWSE
@@ -0,0 +1,9 @@
[ebrowse-hs "ebrowse 5.0" " -x" () ()][ebrowse-ts [ebrowse-cs "*Globals*" () 0() () 0() ]
()()
()
()
()
()
()
()()
]
1 change: 1 addition & 0 deletions extra-admin/cups/spec
@@ -1,2 +1,3 @@
VER=2.1.0
REL=1
SRCTBL="http://cups.org/software/${VER}/cups-${VER}-source.tar.bz2"
1 change: 1 addition & 0 deletions extra-editors/emacs/autobuild/defines
Expand Up @@ -4,3 +4,4 @@ PKGDEP="librsvg gpm giflib libotf m17n-lib gtk-3 hicolor-icon-theme gconf deskto
PKGDES="an operating system that pretends to be an editor (foggy weather isnt it)"

ABRPMAUTOPROVONLY=yes
AB_FLAGS_PIE=0
2 changes: 1 addition & 1 deletion extra-editors/emacs/spec
@@ -1,3 +1,3 @@
VER=24.5
REL=2
REL=3
SRCTBL="http://ftp.gnu.org/gnu/emacs/emacs-$VER.tar.gz"
2 changes: 1 addition & 1 deletion extra-emulation/qemu/spec
@@ -1,3 +1,3 @@
VER=2.4.0
REL=1
REL=2
SRCTBL="https://github.com/qemu/qemu/archive/v$VER.tar.gz"
3 changes: 3 additions & 0 deletions extra-gnome/gnome-vfs/autobuild/beyond
@@ -0,0 +1,3 @@
install -d -m755 "abdist/usr/share/gconf/schemas"
gconf-merge-schema "abdist/usr/share/gconf/schemas/gnome-vfs.schemas" --domain gnome-vfs-2.0 abdist/etc/gconf/schemas/*.schemas
rm -f abdist/etc/gconf/schemas/*.schemas
5 changes: 5 additions & 0 deletions extra-gnome/gnome-vfs/autobuild/defines
@@ -0,0 +1,5 @@
PKGNAME=gnome-vfs
PKGDES="virtual file system libraries for GNOME"
PKGSEC=gnome
PKGDEP="avahi bzip2 gconf gnome-mime-data gnutls krb5 libgcrypt samba"
AUTOTOOLS_AFTER="--enable-samba --with-samba-includes=/usr/include/samba-4.0 --disable-hal --enable-avahi --disable-howl --disable-openssl --enable-gnutls"
11 changes: 11 additions & 0 deletions extra-gnome/gnome-vfs/autobuild/patch
@@ -0,0 +1,11 @@
for files in autobuild/patches/*; do
patch -Np1 -i $files
done

sed -i -s 's|$(srcdir)/auto-test|auto-test|' test/Makefile.am

libtoolize --force
gtkdocize
aclocal
autoconf
automake --add-missing
57 changes: 57 additions & 0 deletions extra-gnome/gnome-vfs/autobuild/patches/enable-deprecated.patch
@@ -0,0 +1,57 @@
diff -up gnome-vfs-2.24.4/daemon/Makefile.am.bak gnome-vfs-2.24.4/daemon/Makefile.am
--- gnome-vfs-2.24.4/daemon/Makefile.am.bak 2010-02-09 13:16:14.000000000 +0100
+++ gnome-vfs-2.24.4/daemon/Makefile.am 2013-03-27 17:01:25.000000000 +0100
@@ -8,7 +8,6 @@ INCLUDES= \
-D_LARGEFILE64_SOURCE \
-D_POSIX_PTHREAD_SEMANTICS \
-D_REENTRANT \
- -DG_DISABLE_DEPRECATED \
-DGNOME_VFS_PREFIX=\"$(prefix)\" \
-DGNOME_VFS_DATADIR=\"$(datadir)\" \
-DGNOME_VFS_LIBDIR=\"$(libdir)\" \
diff -up gnome-vfs-2.24.4/libgnomevfs/Makefile.am.bak gnome-vfs-2.24.4/libgnomevfs/Makefile.am
--- gnome-vfs-2.24.4/libgnomevfs/Makefile.am.bak 2010-02-09 13:16:14.000000000 +0100
+++ gnome-vfs-2.24.4/libgnomevfs/Makefile.am 2013-03-27 17:01:37.000000000 +0100
@@ -19,7 +19,6 @@ INCLUDES = \
-D_LARGEFILE64_SOURCE \
-D_POSIX_PTHREAD_SEMANTICS \
-D_REENTRANT \
- -DG_DISABLE_DEPRECATED \
-DGNOME_VFS_PREFIX=\"$(prefix)\" \
-DGNOME_VFS_BINDIR=\"$(bindir)\" \
-DGNOME_VFS_DATADIR=\"$(datadir)\" \
diff -up gnome-vfs-2.24.4/modules/Makefile.am.bak gnome-vfs-2.24.4/modules/Makefile.am
--- gnome-vfs-2.24.4/modules/Makefile.am.bak 2010-02-09 13:16:14.000000000 +0100
+++ gnome-vfs-2.24.4/modules/Makefile.am 2013-03-27 17:01:45.000000000 +0100
@@ -18,7 +18,6 @@ INCLUDES = \
-D_POSIX_PTHREAD_SEMANTICS \
-D_REENTRANT \
-DSSH_PROGRAM=\"$(SSH_PROGRAM)\" \
- -DG_DISABLE_DEPRECATED \
-DGNOME_VFS_PREFIX=\"$(prefix)\" \
-DGNOME_VFS_DATADIR=\"$(datadir)\" \
-DGNOME_VFS_LIBDIR=\"$(libdir)\" \
diff -up gnome-vfs-2.24.4/programs/Makefile.am.bak gnome-vfs-2.24.4/programs/Makefile.am
--- gnome-vfs-2.24.4/programs/Makefile.am.bak 2010-02-09 13:16:14.000000000 +0100
+++ gnome-vfs-2.24.4/programs/Makefile.am 2013-03-27 17:01:56.000000000 +0100
@@ -4,8 +4,7 @@ INCLUDES = \
-I$(top_srcdir) \
-I$(top_builddir) \
$(TEST_CFLAGS) \
- $(VFS_CFLAGS) \
- -DG_DISABLE_DEPRECATED
+ $(VFS_CFLAGS)

libraries = \
$(top_builddir)/libgnomevfs/libgnomevfs-2.la \
diff -up gnome-vfs-2.24.4/test/Makefile.am.bak gnome-vfs-2.24.4/test/Makefile.am
--- gnome-vfs-2.24.4/test/Makefile.am.bak 2013-03-27 17:01:11.000000000 +0100
+++ gnome-vfs-2.24.4/test/Makefile.am 2013-03-27 17:02:08.000000000 +0100
@@ -6,7 +6,6 @@ INCLUDES = \
-I$(top_builddir)/libgnomevfs \
$(TEST_CFLAGS) \
$(VFS_CFLAGS) \
- -DG_DISABLE_DEPRECATED \
-DMODULES_PATH=\"$(libdir)/vfs/modules\"

if OS_WIN32
32 changes: 32 additions & 0 deletions extra-gnome/gnome-vfs/autobuild/patches/gcrypt-config.patch
@@ -0,0 +1,32 @@
# Allow gnome-vfs-2.24 to build with libgcrypt >= 1.5.0
--- gnome-vfs-2.24.4/configure.in 2010-07-01 12:36:09.000000000 -0300
+++ gnome-vfs-2.24.4-libgcrypt//configure.in 2011-07-22 15:55:02.296325640 -0300
@@ -689,6 +689,16 @@
AM_CONDITIONAL(HAVE_SSL, test x$have_ssl = xtrue)

dnl ****************************
+dnl LibGCrypt 1.5.0
+dnl ****************************
+
+AM_PATH_LIBGCRYPT(1.5.0)
+
+if test "x${LIBGCRYPT_LIBS}" = "x"; then
+ AC_MSG_ERROR([unable to find libgcrypt])
+fi
+
+dnl ****************************
dnl DNS-SD implementations
dnl ****************************
AM_CONDITIONAL(HAVE_AVAHI, false)
@@ -1045,8 +1055,8 @@
dnl ==============================================================================

PKG_CHECK_MODULES(LIBGNOMEVFS, glib-2.0 >= $GLIB_REQUIRED gmodule-no-export-2.0 >= $GLIB_REQUIRED gthread-2.0 >= $GLIB_REQUIRED gobject-2.0 >= $GLIB_REQUIRED gconf-2.0 >= $GCONF_REQUIRED libxml-2.0 >= $XML_REQUIRED gnome-mime-data-2.0 $dbus_requirement)
-LIBGNOMEVFS_CFLAGS="$LIBGNOMEVFS_CFLAGS $OPENSSL_CFLAGS $LIBGNUTLS_CFLAGS $HOWL_CFLAGS $AVAHI_CFLAGS"
-LIBGNOMEVFS_LIBS="$LIBGNOMEVFS_LIBS $OPENSSL_LIBS $LIBGNUTLS_LIBS $HOWL_LIBS $AVAHI_LIBS $RESOLVER_LIBS"
+LIBGNOMEVFS_CFLAGS="$LIBGNOMEVFS_CFLAGS $OPENSSL_CFLAGS $LIBGNUTLS_CFLAGS $HOWL_CFLAGS $AVAHI_CFLAGS $LIBGCRYPT_CFLAGS"
+LIBGNOMEVFS_LIBS="$LIBGNOMEVFS_LIBS $OPENSSL_LIBS $LIBGNUTLS_LIBS $HOWL_LIBS $AVAHI_LIBS $RESOLVER_LIBS $LIBGCRYPT_LIBS"
AC_SUBST(LIBGNOMEVFS_CFLAGS)
AC_SUBST(LIBGNOMEVFS_LIBS)


39 changes: 39 additions & 0 deletions extra-gnome/gnome-vfs/autobuild/patches/gnutls-3.4.0.patch
@@ -0,0 +1,39 @@
diff -uprw gnome-vfs-2.24.4.orig/libgnomevfs/gnome-vfs-ssl.c gnome-vfs-2.24.4/libgnomevfs/gnome-vfs-ssl.c
--- gnome-vfs-2.24.4.orig/libgnomevfs/gnome-vfs-ssl.c 2010-02-09 14:16:14.000000000 +0200
+++ gnome-vfs-2.24.4/libgnomevfs/gnome-vfs-ssl.c 2015-04-14 00:01:51.272451668 +0300
@@ -314,21 +314,6 @@ gnome_vfs_ssl_create (GnomeVFSSSL **hand
#endif
}

-#ifdef HAVE_GNUTLS
-static const int protocol_priority[] = {GNUTLS_TLS1, GNUTLS_SSL3, 0};
-static const int cipher_priority[] =
- {GNUTLS_CIPHER_RIJNDAEL_128_CBC, GNUTLS_CIPHER_3DES_CBC,
- GNUTLS_CIPHER_RIJNDAEL_256_CBC, GNUTLS_CIPHER_ARCFOUR, 0};
-static const int comp_priority[] =
- {GNUTLS_COMP_ZLIB, GNUTLS_COMP_NULL, 0};
-static const int kx_priority[] =
- {GNUTLS_KX_DHE_RSA, GNUTLS_KX_RSA, GNUTLS_KX_DHE_DSS, 0};
-static const int mac_priority[] =
- {GNUTLS_MAC_SHA, GNUTLS_MAC_MD5, 0};
-
-#endif
-
-
/**
* gnome_vfs_ssl_create_from_fd:
* @handle_return: pointer to a #GnomeVFSSSL struct, which will
@@ -437,11 +422,7 @@ gnome_vfs_ssl_create_from_fd (GnomeVFSSS
gnutls_transport_set_ptr (ssl->private->tlsstate,
GINT_TO_POINTER (fd));

- gnutls_protocol_set_priority (ssl->private->tlsstate, protocol_priority);
- gnutls_cipher_set_priority (ssl->private->tlsstate, cipher_priority);
- gnutls_compression_set_priority (ssl->private->tlsstate, comp_priority);
- gnutls_kx_set_priority (ssl->private->tlsstate, kx_priority);
- gnutls_mac_set_priority (ssl->private->tlsstate, mac_priority);
+ gnutls_set_default_priority (ssl->private->tlsstate);

gnutls_cred_set (ssl->private->tlsstate, GNUTLS_CRD_CERTIFICATE,
ssl->private->xcred);

25 changes: 25 additions & 0 deletions extra-gnome/gnome-vfs/autobuild/patches/gnutls-config.patch
@@ -0,0 +1,25 @@
# Allow gnome-vfs-2.24 to build with gnutls >= 2.7.0
# Use pkg-config in place of gnutls own macro since it's not present anymore.
--- a/configure.in 2009-03-07 19:59:53.805507753 +0100
+++ b/configure.in 2009-03-07 18:34:36.928169018 +0100
@@ -686,14 +686,14 @@
AC_MSG_ERROR([*** Can't use both openssl and gnutls at the same time. Please pick one only. ***])
else
AC_CHECK_HEADER(gcrypt.h,, AC_MSG_ERROR([*** Need gcrypt.h to compile with GnuTLS support ***]))
- AM_PATH_LIBGNUTLS(1.0.0, [AC_DEFINE(HAVE_GNUTLS, 1, [Define to 1 if GnuTLS is available])
- have_ssl=true])
+ PKG_CHECK_MODULES(LIBGNUTLS, gnutls >= 1.0.0, [AC_DEFINE(HAVE_GNUTLS, 1, [Define to 1 if GnuTLS is available])
+ have_ssl=true])

if test "x${LIBGNUTLS_LIBS}" = "x"; then
- AM_PATH_LIBGNUTLS(0.5.1, [AC_DEFINE(HAVE_GNUTLS, 1, [Define to 1 if GnuTLS is available])
- AC_DEFINE(GNUTLS_COMPAT, 1, [FIXME])
- have_ssl=true],
- AC_MSG_ERROR([Unable to find GNUTLS]))
+ PKG_CHECK_MODULES(LIBGNUTLS, gnutls >= 0.5.1, [AC_DEFINE(HAVE_GNUTLS, 1, [Define to 1 if GnuTLS is available])
+ AC_DEFINE(GNUTLS_COMPAT, 1, [FIXME])
+ have_ssl=true],
+ AC_MSG_ERROR([Unable to find GNUTLS]))
fi
fi
fi
3 changes: 3 additions & 0 deletions extra-gnome/gnome-vfs/spec
@@ -0,0 +1,3 @@
VER=2.24.4
REL=3
SRCTBL="http://download.gnome.org/sources/gnome-vfs/${VER%.*}/gnome-vfs-$VER.tar.bz2"
7 changes: 7 additions & 0 deletions extra-gnome/vinagre/autobuild/defines
@@ -0,0 +1,7 @@
PKGNAME=vinagre
PKGSEC=gnome
PKGDEP="libsecret gtk-vnc vte-gtk3 telepathy-glib avahi desktop-file-utils dconf shared-mime-info libspice-gtk gnutls freerdp openssh phodav"
BUILDDEP="docbook-xsl intltool itstool spice-protocol"
PKGDES="a VNC Client for the GNOME Desktop"

AUTOTOOLS_AFTER="--enable-rdp --enable-spice"
3 changes: 3 additions & 0 deletions extra-gnome/vinagre/spec
@@ -0,0 +1,3 @@
VER=3.16.1
REL=1
SRCTBL="http://download.gnome.org/sources/vinagre/${VER%.*}/vinagre-$VER.tar.xz"
8 changes: 8 additions & 0 deletions extra-gnome/vino/autobuild/defines
@@ -0,0 +1,8 @@
PKGNAME=vino
PKGEPOCH=1
PKGSEC=gnome
PKGDEP="libnotify x11-lib telepathy-glib gtk-3 libsecret avahi desktop-file-utils gnutls"
BUILDDEP="gtk-doc intltool"
PKGDES="a VNC server for the GNOME desktop"

AUTOTOOLS_AFTER="--disable-http-server --with-secret --enable-gtk-doc"
2 changes: 2 additions & 0 deletions extra-gnome/vino/spec
@@ -0,0 +1,2 @@
VER=3.16.0
SRCTBL="http://download.gnome.org/sources/vino/${VER%.*}/vino-$VER.tar.xz"
13 changes: 13 additions & 0 deletions extra-gnustep/gnustep-base/autobuild/build
@@ -0,0 +1,13 @@
source /etc/profile.d/GNUstep.sh
./configure --prefix=/usr --sysconfdir=/etc/GNUstep \
--with-ffi-include=/usr/lib/libffi-3.1/include \
CC=clang CXX=clang++

sed -i 's/tar -xf $(TIMEZONE_ARCHIVE);/tar -xf $(TIMEZONE_ARCHIVE);chown -R root:root * ;/' NSTimeZones/Makefile.postamble
sed -i 's|.*gnutls_transport_set_lowat.*||' Source/GSSocketStream.m
make VERBOSE=1

make DESTDIR=$PKGDIR install
chown -R root.root $PKGDIR


6 changes: 6 additions & 0 deletions extra-gnustep/gnustep-base/autobuild/defines
@@ -0,0 +1,6 @@
PKGNAME=gnustep-base
PKGSEC=gnustep
PKGDEP="libxslt avahi gmp libobjc2 openssl libffi gnustep-make gnutls icu"
PKGDES="the GNUstep base package"

USECLANG=yes
2 changes: 2 additions & 0 deletions extra-gnustep/gnustep-base/spec
@@ -0,0 +1,2 @@
VER=1.24.8
SRCTBL="ftp://ftp.gnustep.org/pub/gnustep/core/gnustep-base-$VER.tar.gz"
1 change: 1 addition & 0 deletions extra-libs/glib-networking/autobuild/defines
Expand Up @@ -2,4 +2,5 @@ PKGNAME=glib-networking
PKGDES="Glib networking"
PKGSEC=libs
PKGDEP="p11-kit gsettings-desktop-schemas gnutls ca-certs"
BUILDDEP="intltool"
AUTOTOOLS_AFTER="--libexecdir=/usr/lib/glib-networking --with-ca-certificates=/etc/ssl/ca-bundle.crt --disable-installed-tests"
2 changes: 1 addition & 1 deletion extra-libs/glib-networking/spec
@@ -1,3 +1,3 @@
VER=2.44.0
REL=1
REL=2
SRCTBL="http://ftp.gnome.org/pub/gnome/sources/glib-networking/2.44/glib-networking-$VER.tar.xz"
1 change: 1 addition & 0 deletions extra-libs/gloox/spec
@@ -1,2 +1,3 @@
VER=1.0.13
REL=1
SRCTBL="http://camaya.net/download/gloox-$VER.tar.bz2"
3 changes: 1 addition & 2 deletions extra-libs/gnupg/spec
@@ -1,3 +1,2 @@
VER=2.1.6
REL=1
VER=2.1.7
SRCTBL="ftp://ftp.gnupg.org/gcrypt/gnupg/gnupg-$VER.tar.bz2"
6 changes: 6 additions & 0 deletions extra-libs/gsasl/autobuild/defines
@@ -0,0 +1,6 @@
PKGNAME=gsasl
PKGSEC=libs
PKGDEP="gnutls libidn krb5 libgcrypt"
PKGDES="Simple Authentication and Security Layer framework and a few common SASL mechanisms"

AUTOTOOLS_AFTER="--with-gssapi-impl=mit"
3 changes: 3 additions & 0 deletions extra-libs/gsasl/spec
@@ -0,0 +1,3 @@
VER=1.8.0
REL=2
SRCTBL="ftp://ftp.gnu.org/gnu/gsasl/libgsasl-$VER.tar.gz"
5 changes: 4 additions & 1 deletion extra-libs/libarchive/autobuild/defines
@@ -1,6 +1,9 @@
PKGNAME=libarchive
PKGEPOCH=1
PKGDES="a single interface for reading/writing various compression formats"
PKGDEP="acl attr bzip2 expat lzo openssl xz zlib"
PKGSEC=libs

AUTOTOOLS_AFTER="--without-xml2 --without-nettle"
ABTYPE=autotools
RECONF=no
ABSHADOW=no
1 change: 1 addition & 0 deletions extra-libs/libarchive/spec
@@ -1,2 +1,3 @@
VER=3.1.2
REL=1
SRCTBL="http://www.libarchive.org/downloads/libarchive-$VER.tar.gz"
7 changes: 7 additions & 0 deletions extra-libs/libgadu/autobuild/defines
@@ -0,0 +1,7 @@
PKGNAME=libgadu
PKGSEC=libs
PKGDEP="gnutls protobuf-c"
PKGDES="this library implements the client side of the Gadu-Gadu protocol"

# NON GPL COMPLIANT NOW...
AUTOTOOLS_AFTER="--with-openssl"
4 changes: 4 additions & 0 deletions extra-libs/libgadu/autobuild/patch
@@ -0,0 +1,4 @@
patch -Np1 -i autobuild/patches/protobuf-c.patch

./protobufgen.sh

16 changes: 16 additions & 0 deletions extra-libs/libgadu/autobuild/patches/protobuf-c.patch
@@ -0,0 +1,16 @@
diff -Npru libgadu-1.12.0.orig/protobufgen.sh libgadu-1.12.0/protobufgen.sh
--- libgadu-1.12.0.orig/protobufgen.sh 2014-06-13 18:41:37.000000000 +0000
+++ libgadu-1.12.0/protobufgen.sh 2014-07-16 20:06:14.570039033 +0000
@@ -6,12 +6,5 @@ if [ $? != 0 ] ; then
exit -1
fi

-sed -i 's/<google\/protobuf-c\/protobuf-c.h>/"protobuf.h"/g' packets.pb-c.h
-
-if ! cat packets.pb-c.c | grep "PROTOBUF_C_NO_DEPRECATED" > /dev/null; then
- echo "Warning: protobuf-c-compiler < 0.14 detected, trying to fix the output"
- sed -i 's| NULL,NULL /\* reserved1, reserved2 \*/| 0, 0, NULL, NULL|g' packets.pb-c.c
-fi
-
mv packets.pb-c.h include
mv packets.pb-c.c src
3 changes: 3 additions & 0 deletions extra-libs/libgadu/spec
@@ -0,0 +1,3 @@
VER=1.12.1
REL=1
SRCTBL="http://github.com/wojtekka/libgadu/releases/download/$VER/libgadu-$VER.tar.gz"
1 change: 1 addition & 0 deletions extra-libs/libimobiledevice/spec
@@ -1,2 +1,3 @@
VER=1.2.0
REL=1
SRCTBL="http://www.libimobiledevice.org/downloads/libimobiledevice-$VER.tar.bz2"
4 changes: 4 additions & 0 deletions extra-libs/libmicrohttpd/autobuild/beyond
@@ -0,0 +1,4 @@
install -Dm644 src/include/platform.h \
$PKGDIR/usr/include/$pkgname/platform.h
sed -i 's#Cflags: -I${includedir}#Cflags: -I${includedir} -I${includedir}/libmicrohttpd#' \
$PKGDIR/usr/lib/pkgconfig/libmicrohttpd.pc
6 changes: 6 additions & 0 deletions extra-libs/libmicrohttpd/autobuild/defines
@@ -0,0 +1,6 @@
PKGNAME=libmicrohttpd
PKGDES="embedding HTTP server functionality"
PKGSEC=libs
PKGDEP="gnutls libgcrypt file curl"

AUTOTOOLS_AFTER="--enable-largefile --enable-curl --enable-messages --with-pic"
3 changes: 3 additions & 0 deletions extra-libs/libmicrohttpd/spec
@@ -0,0 +1,3 @@
VER=0.9.42
REL=1
SRCTBL="ftp://ftp.gnu.org/gnu/libmicrohttpd/libmicrohttpd-$VER.tar.gz"
19 changes: 19 additions & 0 deletions extra-libs/libvirt/autobuild/build
@@ -0,0 +1,19 @@
export PYTHON=`which python2`
export LDFLAGS+=" -lX11"
export RADVD=/usr/bin/radvd

./configure --prefix=/usr --sbindir=/usr/bin \
--with-storage-lvm --without-xen --with-udev --without-hal --disable-static \
--with-init-script=systemd \
--with-qemu-user=nobody --with-qemu-group=nobody \
--without-netcf --with-interface --with-lxc \
--with-pm-utils
make
make install DESTDIR=$PKGDIR

chown -R 0:78 $PKGDIR/var/lib/libvirt/qemu/channel/target/
chmod 0770 $PKGDIR/var/lib/libvirt/qemu/channel/target/

rm -rf \
$PKGDIR/etc/sysconfig \
$PKGDIR/etc/rc.d

0 comments on commit a3ec29d

Please sign in to comment.