Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Null check Error on Discussion page #221

Merged
merged 2 commits into from Dec 12, 2023

Conversation

SharmaDhruv2511
Copy link
Contributor

@SharmaDhruv2511 SharmaDhruv2511 commented Dec 8, 2023

Description

There is error of null check on discussions page and that's why discussion page is not loading. This issue resolve that error

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
#220

Type of change

Bug

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please include screenshots below if applicable.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@chandansgowda chandansgowda changed the title fix: Null check Operator on Discussion page fix: Null check Error on Discussion page Dec 9, 2023
@chandansgowda chandansgowda added bug Something isn't working codepeak-23 Part of CodePeak 2023 labels Dec 9, 2023
@SharmaDhruv2511
Copy link
Contributor Author

Done with the checklist @chandansgowda

@chandansgowda
Copy link
Member

We will have to wait for @Aarush-Acharya to review the PR since he was the one who worked on the Discussion feature. Until then please add a screen recording showing the fix.

@Aarush-Acharya
Copy link
Contributor

Hey @chandansgowda apologies for the inactivity

@Aarush-Acharya
Copy link
Contributor

Hey @chandansgowda this is just ensuring null safety there is not any other change a couple of null checks, and it will safegaurd from null errors so its safe from my side thanks

@chandansgowda
Copy link
Member

Great job @SharmaDhruv2511

@chandansgowda chandansgowda merged commit 35b08e4 into AOSSIE-Org:master Dec 12, 2023
@SharmaDhruv2511 SharmaDhruv2511 deleted the sharmadhruv/fix branch December 19, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codepeak-23 Part of CodePeak 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants