Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pom to build updatesite #18

Merged
merged 3 commits into from
Jun 10, 2020
Merged

Add pom to build updatesite #18

merged 3 commits into from
Jun 10, 2020

Conversation

ingomohr
Copy link
Contributor

@ingomohr ingomohr commented Jun 8, 2020

Local Test

I installed the feature from the locally built updatesite. The theme looks as before to me. Maybe you could doublecheck.

Thoughts

I think the product and the Export folder could be removed (later).
Maybe there's a way to establish all versions as Composite Updatesite via Github Actions (I didn't yet check that out, though),

Note I'm looking forward to any review feedback. :) Maybe you find something to be improved, as well. :)

Copy link
Owner

@AObuchow AObuchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works perfectly :) See minor comments inline.

Realistically, this is good to merge IMO (I could address the comments myself).
Amazing work @ingomohr !

<feature id="aobuchow.themes.moderndark.feature">
<category name="aobuchow.themes.moderndark.update" />
</feature>
<category-def name="aobuchow.themes.moderndark.update" label="Modern Dark Theme update site">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the label to Modern Dark Theme so that it looks a bit nicer in the software install wizard? :)
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed

<modules>
<module>aobuchow.themes.moderndark</module>
<module>aobuchow.themes.moderndark.feature</module>
<module>releng-updatesite</module>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth including the product as a module to build, as I recently found out you can use a .product to configure Eclipse Preferences (currently, all preferences are set in CSS).

If we decide to include the product, it's feature needs to be updated to aobuchow.themes.moderndark.feature

However, I think this could be for a future PR :) It's not a requirement for this to get merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added product

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The built product won't start on my machine (MacOS Catalina). Did it start on yours before?
I checked it against https://github.com/vogellacompany/rcpdemo/tree/master/com.vogella.tasks.product but that one also doesn't after I built it w/ Maven.
Maybe I'm missing something...?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I'll look into it or make a bug about it at least.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing I recommend to use https://github.com/vogellacompany/tycho-example

@AObuchow
Copy link
Owner

AObuchow commented Jun 9, 2020

* I used the Tycho tutorial as template
  
  * https://www.vogella.com/tutorials/EclipseTycho/article.html#using-maven-tycho-to-build-eclipse-components

Great resource :D @vogella

* I (2nd commit) also added a `yml`script to have Github automatically build the updatesite on every push to the Git repo.

I haven't tested this but it looks sane to me :)

Thoughts

I think the product and the Export folder could be removed (later).

The Export folder can definitely be removed. I might want to keep the product folder.

Maybe there's a way to establish all versions as Composite Updatesite via Github Actions (I didn't yet check that out, though),

This is a very interesting idea, I'll have to look into it.
@PyvesB comment here might be relevant/interesting. I'm planning to do something similar.

Note I'm looking forward to any review feedback. :) Maybe you find something to be improved, as well. :)

It was a challenge for me to find something that could be improved in this PR ;)

@AObuchow AObuchow mentioned this pull request Jun 9, 2020
@ingomohr ingomohr force-pushed the master branch 4 times, most recently from 2a9deee to b210602 Compare June 9, 2020 19:47
@AObuchow
Copy link
Owner

Looks good to me! Merging.

Amazing first PR @ingomohr, very grateful for the work you did here :)

@AObuchow AObuchow merged commit df3e1f6 into AObuchow:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants