Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r0 in m or cm? #88

Closed
andrewpaulreeves opened this issue Oct 7, 2022 · 2 comments · Fixed by #92
Closed

r0 in m or cm? #88

andrewpaulreeves opened this issue Oct 7, 2022 · 2 comments · Fixed by #92
Labels
bug docs

Comments

@andrewpaulreeves
Copy link
Contributor

I've been using some functions from atmos_conversions for converting r0 -> cn2 and back. Sometimes r0 is listed in the docs as being is cm, sometimes in m. Is it really in cm sometimes? From a quick look at the equations I would guess its mostly in m.
@matthewtownson
Copy link
Member

Is it easy for you to update the docstrings in the functions? If not, then I can sort it in the next month or so.

@ojdf
Copy link
Contributor

ojdf commented Nov 22, 2022

it definitely returns and expects r0 in m, the docstrings for r0_to_cn2 and r0_to_seeing are wrong

matthewtownson added a commit to matthewtownson/aotools that referenced this issue Jun 29, 2023
@matthewtownson
Unit typos in atmos_conversions.py
df373ab 
Fix the errors in _r0_to_cn2_ and r0_to_seeing as described in  
AOtools#88
@matthewtownson matthewtownson mentioned this issue Jun 29, 2023
Merged
@matthewtownson matthewtownson linked a pull request Jun 29, 2023 that will close this issue
Unit typos in atmos_conversions.py #92
Merged
matthewtownson added a commit that referenced this issue Aug 25, 2023
@matthewtownson
Unit typos in atmos_conversions.py
0be8a2a 
Fix the errors in _r0_to_cn2_ and r0_to_seeing as described in  
#88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unit typos in atmos_conversions.py matthewtownson/aotools
3 participants
@andrewpaulreeves @matthewtownson @ojdf