-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for 0.2 #19
Merged
Merged
Updates for 0.2 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewpaulreeves
commented
May 13, 2017
- Add some more docs
- moving optical propagation from "turbulence" to top namespace, as its general propagation, not just for turbulence.
- Previously, if an inversion in the infinite phase screen failed (due to a linear algebra error using a Cholsky decomposition), a different method would be used. However, this resulted in unpredictable results. Now if the Cholsky fails, just throw and error. (Usually the error can be fixed by using a large (more course) pixel scale
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
=======================================
Coverage 69.59% 69.59%
=======================================
Files 21 21
Lines 980 980
=======================================
Hits 682 682
Misses 298 298
Continue to review full report at Codecov.
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.