Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should "Visualizer" appear in the class structure? #6

Closed
mstimberg opened this issue Dec 9, 2022 · 1 comment
Closed

Should "Visualizer" appear in the class structure? #6

mstimberg opened this issue Dec 9, 2022 · 1 comment

Comments

@mstimberg
Copy link

[Issue opened as part of review openjournals/joss-reviews#4944]

The class structure diagram in the wiki and the paper contains the Visualizer class, but if I understand correctly, there is no such class in the C++ code, instead visualization is typically done with external tools (e.g. Python scripts). It seems odd to include it in the UML diagram in that case.
@mstimberg mstimberg mentioned this issue Dec 9, 2022
Closed
@JDatPNW
Copy link
Contributor

JDatPNW commented Jan 7, 2023

270ebdc

@JDatPNW JDatPNW closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstimberg @JDatPNW